Made pickles not generate files if build fails or is aborted.

immeraufdemhund · Mar 20, 2017 · dac23f4 · dac23f4
1 parent cb2ca2e
commit dac23f4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/pom.xml b/pom.xml
@@ -6,7 +6,7 @@
 
     <groupId>com.robertsnyder.pickles</groupId>
     <artifactId>pickles-notifier</artifactId>
-    <version>1.0.2-SNAPSHOT</version>
+    <version>1.0.2</version>
     <packaging>hpi</packaging>
 
     <parent>

diff --git a/src/main/java/hudson/plugins/pickles/PicklesNotifier.java b/src/main/java/hudson/plugins/pickles/PicklesNotifier.java
@@ -10,6 +10,7 @@
 import hudson.model.AbstractBuild;
 import hudson.model.AbstractProject;
 import hudson.model.BuildListener;
+import hudson.model.Result;
 import hudson.plugins.pickles.utilities.BuildPicklesArguments;
 import hudson.plugins.pickles.utilities.FindPicklesInstallation;
 import hudson.tasks.BuildStepDescriptor;
@@ -70,8 +71,13 @@ public BuildStepMonitor getRequiredMonitorService() {
 
     @Override
     public boolean perform(AbstractBuild<?, ?> build, Launcher launcher, BuildListener listener) throws InterruptedException, IOException {
-        ArgumentListBuilder args = new ArgumentListBuilder();
+        Result result = build.getResult();
+        if(result == Result.ABORTED || result == Result.FAILURE){
+            listener.getLogger().println("[pickles] Build is Aborted or Failed, skipping pickles generation");
+            return true;
+        }
 
+        ArgumentListBuilder args = new ArgumentListBuilder();
         EnvVars env = build.getEnvironment(listener);
         env.putAll(build.getBuildVariables());