Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record exceptions when using Opentelemetry_trace #71

Closed
ajbt200128 opened this issue Oct 14, 2024 · 3 comments · Fixed by #72
Closed

Record exceptions when using Opentelemetry_trace #71

ajbt200128 opened this issue Oct 14, 2024 · 3 comments · Fixed by #72

Comments

@ajbt200128
Copy link
Contributor

In the normal otel code, exceptions are reported properly here, but this doesn't happen in Opentelemetry_trace here. Ideally these two functions are identical or near identical
@ajbt200128
Copy link
Contributor Author

Related: #50

c-cube added a commit that referenced this issue Oct 16, 2024
@c-cube
fix otel.trace: record exception in with_span
b720ea0 
close #71
@c-cube c-cube mentioned this issue Oct 16, 2024
Merged
@c-cube
Copy link
Member

c-cube commented Oct 16, 2024

Does #72 solve your issue? :)

@ajbt200128
Copy link
Contributor Author

yup! thanks so much

c-cube added a commit that referenced this issue Oct 17, 2024
@c-cube
fix otel.trace: record exception in with_span
041d05e 
close #71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix otel.trace: record exception in with_span imandra-ai/ocaml-opentelemetry
2 participants
@c-cube @ajbt200128