Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opentelemetry_client_ocurl.cleanup does not flush all traces before shutting down properly #69

Closed
ajbt200128 opened this issue Oct 11, 2024 · 3 comments

Comments

@ajbt200128
Copy link
Contributor

When using the Opentelemetry_client_ocurl collector, if we call cleanup on the backend, not all traces are flushed.

One can reproduce this by setting up the backend, start tracing, send many of them, and then call cleanup right before exiting. When I call Backend.tick () first, all traces will appear everytime. We should probably just call Backend.tick in the cleanup function

@ajbt200128
Copy link
Contributor Author

Related #68 for why one might want to shut down a backend early

c-cube added a commit that referenced this issue Oct 16, 2024
this helps flushing signals that are being batched.

close #69
c-cube added a commit that referenced this issue Oct 16, 2024
this helps flushing signals that are being batched.

close #69
@c-cube
Copy link
Member

c-cube commented Oct 16, 2024

#74 should fix this I think.

@c-cube c-cube closed this as completed Oct 16, 2024
@ajbt200128
Copy link
Contributor Author

Thanks!

c-cube added a commit that referenced this issue Oct 17, 2024
this helps flushing signals that are being batched.

close #69
c-cube added a commit that referenced this issue Oct 17, 2024
this helps flushing signals that are being batched.

close #69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants