Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImgLabeling conversions use suboptimal tmp directory #286

Open
ctrueden opened this issue Sep 12, 2023 · 0 comments
Open

ImgLabeling conversions use suboptimal tmp directory #286

ctrueden opened this issue Sep 12, 2023 · 0 comments
Milestone

Comments

@ctrueden
Copy link
Member

In the Labeling <-> ImgLabeling conversion code in convert.py, temporary paths of the form "./tmp" and os.getcwd() + "/tmp" are used. There are a couple of issues with this:

  1. Inconsistency between those two expressions.
  2. Use of forward slashes might not work as expected on Windows (testing probably needed).
  3. Creation and use of temp folders from the CWD is generally considered bad practice. Better is to use dedicated temp file management functions of the language standard library. In Python this would be the tempfile module.
@ctrueden ctrueden added this to the unscheduled milestone Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant