-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The documentation on crop()
is confusing
#2293
Labels
kind: API
missing or awkward public APIs
Comments
Adding to the confusion, |
This was referenced Jul 28, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See https://docs.rs/image/0.25.2/image/enum.DynamicImage.html#method.crop
In
image
v0.25.2 the documentation forcrop()
states:It also took me a while to get what "does not modify the object" actually refers to. At first I thought that maybe it returns a view into the image or something. But no, it actually returns a different buffer altogether.
It's weird that it talks about 0.24 as if it's in the future in docs for v0.25. And the signatures are still different. I guess that's a work item for 0.26 now.
The text was updated successfully, but these errors were encountered: