-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken APNG is produced with StreamWriter
#411
Comments
Thanks for reporting this! The good news is that I was able to reproduce the issue. The bad news is that I'm not sure streaming encoding of APNGs ever worked, and even after a whole bunch of digging through the code I'm really not sure where to start on figuring out what's going on. At various times it seems to write corrupt deflate streams, incorrect sequence numbers, too many fcTL chunks, and occasionally mixes up whether a frame should be encoded with IDAT or fdAT chunks. There's probably a lesson to be learned here about accepting large PRs without any tests... At this point I'm not quite sure what to do. The fact that this wasn't noticed until years after the feature was added suggests that it isn't a particularly important feature, which makes it hard for me to justify spending the considerable amount of additional time on it that I suspect would be needed to get things into a reasonable state. Stripping out streaming APNG encoding isn't especially appealing, but may end up being the least bad option 😞 |
Oh, that's unfortunate... Maybe I'll write a fallback routine to buffered write when I need to write multiple frames. Thanks! |
This code produces broken APNG without any errors:
The text was updated successfully, but these errors were encountered: