Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Iron's Spells 'n Spellbooks Compat #77

Open
Niconoko opened this issue Jul 22, 2023 · 5 comments
Open

[Feature]: Iron's Spells 'n Spellbooks Compat #77

Niconoko opened this issue Jul 22, 2023 · 5 comments
Assignees
Labels
type: enhancement New feature or request

Comments

@Niconoko
Copy link

What is the new feature or improvement?

https://www.curseforge.com/minecraft/mc-mods/irons-spells-n-spellbooks
The mod got holy spells and them seem to not work when shooting undead.

@Niconoko Niconoko added the type: enhancement New feature or request label Jul 22, 2023
@SiverDX
Copy link

SiverDX commented Sep 4, 2023

@betterworld-sjq
Copy link

You do this by editing the config, example for 1.19.2:

Damage source: https://github.com/iron431/Irons-Spells-n-Spellbooks/blob/f9f259bae4b1c3514dfc7cad9c74c5001f3c901f/src/main/java/io/redspace/ironsspellbooks/spells/SpellType.java#L326

Config:

holyDamage = ["holy", "guiding_bolt_spell", "wisp_spell"]

For 1.20.x it seems to use school types https://github.com/iron431/Irons-Spells-n-Spellbooks/blob/49f6d7619d4a4ded27404e9606a405b32f91bb17/src/main/java/io/redspace/ironsspellbooks/datagen/DamageTypeTagGenerator.java#L18

Excuse me, I don't quite get it as to 1.20.x ones. I only find holyMaterials =["silver"] in config. And how to add Iron's spell things?

@betterworld-sjq
Copy link

https://github.com/illusivesoulworks/consecration/blob/1.20.x/common/src/main/resources/data/consecration/tags/damage_type/holy.json

I wrote like this
{
"replace": false,
"values": ["consecration:holy", "irons_spellbooks:holy_magic", "holy_magic"]
}
But it didn't work

@SiverDX
Copy link

SiverDX commented Oct 25, 2023

check your log, adding just "holy_magic" likely broke the tag because that value doesnt exist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants