Skip to content
This repository has been archived by the owner on May 26, 2020. It is now read-only.

SpellChecker isn't enabled when turned on #50

Open
ikarago opened this issue Dec 12, 2019 · 4 comments
Open

SpellChecker isn't enabled when turned on #50

ikarago opened this issue Dec 12, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@ikarago
Copy link
Owner

ikarago commented Dec 12, 2019

The SpellChecker doesn't work when booting the app; it needs to be turned off and back on again in order to work.

Repo steps:

  1. Open the app with the SpellChecker toggle enabled in Settings
  2. Type something with a spelling error.
  3. SpellChecker doesn't mark the incorrectly spelled word.

Workaround mode:
4) Open Settings
5) Turn off Spell Checker
6) Turn it back on again
7) Close the Settings Dialog
The incorrectly spelled word will now be marked as such.

@ikarago ikarago added the bug Something isn't working label Dec 12, 2019
@ikarago ikarago added this to the v1.9.3.x milestone Dec 12, 2019
@yaira2
Copy link
Contributor

yaira2 commented Dec 24, 2019

Just a note, any new words that are misspelled are underlined but existing ones are not. I am fairly certain this is bug with the TextBox control and not how you are implementing it. Maybe this is something for the WinUI repo.

@prayaas-a
Copy link
Contributor

Just a note, any new words that are misspelled are underlined but existing ones are not. I am fairly certain this is bug with the TextBox control and not how you are implementing it. Maybe this is something for the WinUI repo.

+1. Literally just discovered the same thing. If you start with a blank document, spellcheck works if enabled in a new instance. Existing words don't get underlined unless you go tap/click on them. I can think of workarounds but they'd likely be impractical. Seems like a TextBox control issue.

@yaira2
Copy link
Contributor

yaira2 commented Dec 25, 2019

@prayaas-a What potential workaround can you think of? The one I have been thinking about is reloading the text after the setting is changes, its kind of messy but it might be the best solution for now.

@prayaas-a
Copy link
Contributor

@prayaas-a What potential workaround can you think of? The one I have been thinking about is reloading the text after the setting is changes, its kind of messy but it might be the best solution for now.

Yes, I was thinking of reloading all the text. Not even sure if it would work. It depends on where the bug is. If it's a focus bug (i.e. the text needs to be focused at some point to be spell checked), we could show an overlap ("applying") while we iterate through and focus on all the characters. Both solutions are very messy.

@ikarago ikarago removed this from the v1.10.0.x milestone Jan 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants