Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we include a Dockerfile? #10

Open
ibnesayeed opened this issue Feb 19, 2019 · 4 comments
Open

Should we include a Dockerfile? #10

ibnesayeed opened this issue Feb 19, 2019 · 4 comments

Comments

@ibnesayeed
Copy link

I am wondering, will it be helpful to add a Dockerfile in the repo that includes Chromium/Google Chrome and other run-time requirements to make all the tools function as expected?

@machawk1
Copy link

Squidwarc's Dockerfile might be useful here as a loose basis for including Chromium.

@ato
Copy link
Member

ato commented Feb 19, 2019

Sure. I don't use docker much myself so happy to take your advice on that.

@ibnesayeed
Copy link
Author

@ato can you list/describe all the stuff needed (i.e., dependencies and requirements) to put it together? If you were to set it up on a bare bone Ubuntu machine (for example), what would be the steps needed to put everything together? Roughly speaking, we will need some version of JRE, Chromium/Google Chrome, some specific environments variables and any other considerations?

@ato
Copy link
Member

ato commented Feb 25, 2019

At compile time: openjdk-8-jdk, maven.
At runtime: openjdk-8-jre, chromium/chrome.

Java 11 should also be fine, whichever is available.

Set env var BROWSER to the chromium/chrome executable. It may also be good to cap the java heap size by running it like like this:

java -Xmx128m -jar jwarc.jar <args>

Otherwise Java defaults to a percentage of the system's total RAM which can be unreasonably high on a large memory system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants