Release candidate orange (rebased) #419
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmbc
changed the title
zmbc
requested review from
albrja,
hussain-jafari,
patricktnast,
rmudambi and
stevebachmeier
as code owners
|
@zmbc We do not want to merge this now since we would want to do significant testing with this large of a refactor. But this is the release-candidate branch that we should branch off of for all features for the next release. |
Refactors pseudopeople to create a class that encapsulates dataset schema, the data to be noised, a randomness stream, and the missingness attribute in one place. - *Category*: Refactor - *JIRA issue*: [MIC-4865](https://jira.ihme.washington.edu/browse/MIC-4865) -creates new class to hold dataset schema, a pandas dataframe, a randomness stream, and a missingness bool dataframe -updates fixtures and tests to reflect changes in the refactor Testing All tests pass
Mic-4865/Refactor/rename dataset Renames Dataset to Dataset Schema and DatasetData to Dataset. - *Category*: Refactor - *JIRA issue*: [MIC-4865](https://jira.ihme.washington.edu/browse/MIC-4865) -renames current dataset class to dataset_schema -renames DatasetData to Dataset -updates docstrings Testing All tests pass
Mic-4568/make-format Adds Makefile to run formatters - *Category*: Feature - *JIRA issue*: [MIC-4568](https://jira.ihme.washington.edu/browse/MIC-4568) -adds Makefile to include the following commands (which can be run from the terminal within your conda environment) for quality of life improvement for development: -`make format` which is running black and isort on the codebase -`make integration` which is running `pytest --runslow tests/` -`make unit` which is running `pytest --runslow tests/unit/ ` Testing Ran make format and saw expected behavior.
Mic-5187/call-overload Fixes one instance of call-overload - *Category*: Feature - *JIRA issue*: [MIC-5187](https://jira.ihme.washington.edu/browse/MIC-5187) -fixes one instance of call overload
* use np.random.Generator instead of np.Generator * fix all errors * Revert "use np.random.Generator instead of np.Generator" This reverts commit 8e41c58. * add mocker * add return * remove ignore * Update pyproject.toml * revert attempted change * add space
Mic-5186/numpy-var-annotated
* install available stubs; skip scipy * fix union-attr * remove old/temp fix for Sphinx issue 8127; pin sphinx-rtd-theme>=0.6 to remove theme error * fix return-value * fix var-annotaged * fix no-any-return
* fix misc mypy errors * fix mypy errors introduced by incremented pyarrow-stubs version
Category: refactor Define and use noise configuration object. Testing All tests pass.
Category: refactor JIRA issue: MIC-5359 Remove references to NodeValue and NestedDict types from layered config tree. Testing mypy passes.
Category: typing JIRA issue: MIC-5440 Use pipe syntax instead of Optional and/or Union. Testing mypy succeeds.
Albrja/mic-5414/vtu-FuzzyChecker Import FuzzyChecker from VTU - *Category*: Test - *JIRA issue*: [MIC-5414](https://jira.ihme.washington.edu/browse/MIC-5414) -import FuzzyChecker from VTU Testing All tests pass
Category: typing JIRA issue: MIC-5376 Typing updates related to LayeredConfigTree errors. Testing All tests pass (including slow tests).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release candidate orange (rebased)
Description
Re-applies the changes from #387, #389, and #393 to main, by applying a new PR #418 to make them compatible.
Testing
pytest --runslow)