Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/custom-component add custom component render and classNames #106

Closed
wants to merge 1 commit into from
Closed

feature/custom-component add custom component render and classNames #106

wants to merge 1 commit into from

Conversation

dmitrykuznetsovdev
Copy link

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 95.62% when pulling c4cae1c on batmandarkside:feature/custom-component into f7ad149 on igorprado:master.

Copy link

@MomchilGorchev MomchilGorchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a really valid use case

@nandastone
Copy link

nandastone commented Feb 8, 2018

imo the component isn't complete without the ability to override the display component. There's no way to add supporting content or use custom CSS.

Can we get this or #54 merged, and if not some guidance on what first needs to be fixed?

@nandastone
Copy link

I'm using a hacky solution for replacing just the internal elements of the modal (not the wrapper or modal item).

Pass through the real content via the children prop, and hide the default elements:

children: (
  <div className='new-content'>
    <h4 className='new-title'>{title}</h4>
    <div className='new-message'>{message}</div>
  </div>
)
.notification-title,
.notification-message,
.notification-dismiss { display: none; }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants