Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library incompatible with React 17 #182

Open
detrash08 opened this issue Apr 7, 2021 · 5 comments
Open

library incompatible with React 17 #182

detrash08 opened this issue Apr 7, 2021 · 5 comments

Comments

@detrash08
Copy link

I've recently updated my project to react 17.0.2 and seems that the library is not compatible.
Are you planning to update compatibility to React 17?

I have react-notification-system updated to verson 0.4.0

@chrisgbaker
Copy link

Was also curious about this, as we are looking to move to React 17 in the near future

@oleksandrbyk
Copy link

@detrash08 for the workaround, I used 0.2.17 and was able to resolve the issue with React 17

@cristian-sima
Copy link

cristian-sima commented Jan 28, 2022

@detrash08 for the workaround, I used 0.2.17 and was able to resolve the issue with React 17

The peer-dep will force you to install 2 React versions. (one for 16 and one for 17)

@cristian-sima
Copy link

I tried it and it works. You have to delete the peerDep from package.json and also to add this dep create-react-class

@Oskku
Copy link

Oskku commented Oct 29, 2022

I tried it and it works. You have to delete the peerDep from package.json and also to add this dep create-react-class

So you delete the perDeep Object ? and this dep where did you add it ? to the package json of the react notification or your entire project packafge.json ? and do you get the problem what i get now , i try to call the fork version, i get a problem said module cannot resolve react redux notification system and redux ? can please write me the step what u did to make it work and how you call the forked version to your package.json ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants