Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Matcher] Fix misbehaviour on validate_content_type_of matcher (#201) #202

Conversation

Mth0158
Copy link
Collaborator

@Mth0158 Mth0158 commented Oct 25, 2023

Closes #201

The error was due to #183 that implemented a check on the custom_message matcher for content_type.
It was:

  • always looking to check the validity of the custom_message matcher even if not present
  • looking on all errors of the field (meaning not content_type errors also) to find this message

Both these behaviours have been removed.

@Mth0158
Copy link
Collaborator Author

Mth0158 commented Oct 25, 2023

@igorkasyanchuk I would love to work a bit more on the message matcher, I think a lot of things could be refactored, we could also improve reliability with a better test suit on this part. What do you think?

@igorkasyanchuk igorkasyanchuk merged commit 074f08c into igorkasyanchuk:master Oct 26, 2023
26 checks passed
@igorkasyanchuk
Copy link
Owner

@Mth0158 Sure, do what you want and what can be good for the project. I don't have much time to focus on this project so if you can support it would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Existing specs started failing after upgrade to 1.1.0. Probably an issue with the matcher
2 participants