Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Options to help using the timeline for music-related applications #49

Open
aaronsantiago opened this issue Jul 17, 2024 · 2 comments

Comments

@aaronsantiago
Copy link

aaronsantiago commented Jul 17, 2024

Currently there are a couple features that would help using the timeline for music:

  • The "denominators" for the tick marks between numbers is hardcoded to a very non-musical 1, 2, 5, 10. Exposing this via configuration would help dramatically--for music or for dance 1, 2, 4, 8 etc. would be preferred.
    const denominators = [1, 2, 5, 10];
  • The numbers above the timeline are treated as if they are always seconds, making things confusing when treating the timeline in terms of beats, as they additionally get converted into minutes/hours as the timeline grows. Adding a callback to replace _formatUnitsText dynamically would be optimal, as I could then implement "numbers only" display, or counting to 8s, etc.
    _formatUnitsText = (ms: number, isSeconds = false): string => {
@ievgennaida
Copy link
Owner

ievgennaida commented Jul 17, 2024

Hello @aaronsantiago
Thank you for the feedback.

  1. Denominators I can make configuble, but cannot do this week.
  2. format units -> you can just override existing function.

I would appreciate it if you could describe your usecase so other important changes will be also incorporated.

@ievgennaida
Copy link
Owner

@aaronsantiago Do you have any mock-up or reference with the expected outcome (overall)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants