Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible errors in the Detached/Attached JWS examples #537

Open
alessandrodi opened this issue Apr 29, 2024 · 1 comment
Open

Possible errors in the Detached/Attached JWS examples #537

alessandrodi opened this issue Apr 29, 2024 · 1 comment

Comments

@alessandrodi
Copy link

Hello everyone!

Thank you very much for your efforts to write the GNAP Protocol. We are in the process of implementing it and, while we are testing our code using the examples in the specs, we might have found some discrepancies between the text written in the specs and what has been encoded in the examples.

The "Detached-JWS" header in https://datatracker.ietf.org/doc/html/draft-ietf-gnap-core-protocol-20#section-7.3.3-17 and the Attached JWS here https://datatracker.ietf.org/doc/html/draft-ietf-gnap-core-protocol-20#section-7.3.4-15 when decoded in www.jwt.io both have same header:

{
  "alg": "RS256",
  "created": 1618884475,
  "htm": "POST",
  "kid": "gnap-rsa",
  "typ": "gnap-binding+jwsd",
  "uri": "https://server.example.com/gnap"
}

I think since GNAP version 19 "typ" should not have "+", and more specifically for the Attached JWS the "typ" should be "gnap-binding-jws" (without "d" in the end).

Can you verify?

Best regards,

Alessandro

@jricher
Copy link
Collaborator

jricher commented Apr 29, 2024

You are correct that the examples have the incorrect values. The JWT types were updated in a relatively late review #533, and the breaking change was announced to the list here https://mailarchive.ietf.org/arch/msg/txauth/tte1trURckR71vYvX5JUFpwQiQk/ -- it looks like we missed updating the encoded examples though, so good catch! We'll make sure the examples are re-generated during the RFC Editor review process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants