Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update 404.html #468

Merged
merged 1 commit into from
Jun 20, 2024
Merged

fix: Update 404.html #468

merged 1 commit into from
Jun 20, 2024

Conversation

kesara
Copy link
Member

@kesara kesara commented Jun 20, 2024

Fixes #467

@kesara kesara requested a review from microamp June 20, 2024 01:45
microamp
microamp approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@microamp microamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I noticed that the format had changed from txt to html - in case that wasn't intentional.

@kesara
Copy link
Member Author

kesara commented Jun 20, 2024

Looks good to me. I noticed that the format had changed from txt to html - in case that wasn't intentional.

Yes, it's intentional. See ietf/www.ietf.org#17
I changed the domain to rfc-editor.org to match the rest of the 404 template 1.

Footnotes

  1. https://github.com/ietf-tools/www/blob/main/ietf/templates/404.html#L52 ↩

@kesara kesara merged commit 010f508 into main Jun 20, 2024
5 checks passed
@kesara kesara deleted the kesara-patch-1 branch June 20, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microamp microamp microamp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update 404 template
2 participants
@kesara @microamp