Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add www.ietf.org k8s configuration #453

Merged
merged 22 commits into from
Jun 17, 2024
Merged

feat: Add www.ietf.org k8s configuration #453

merged 22 commits into from
Jun 17, 2024

Conversation

kesara
Copy link
Member

@kesara kesara commented May 28, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.08%. Comparing base (b7a8df2) to head (ea2e384).
Report is 19 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #453       +/-   ##
===========================================
+ Coverage   82.81%   96.08%   +13.27%     
===========================================
  Files         126      153       +27     
  Lines        2612     3293      +681     
===========================================
+ Hits         2163     3164     +1001     
+ Misses        449      129      -320     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kesara kesara force-pushed the feat/k8s branch 10 times, most recently from cba940d to ece5886 Compare June 10, 2024 21:36
@kesara kesara marked this pull request as ready for review June 11, 2024 01:36
@kesara kesara requested review from microamp and NGPixel June 11, 2024 01:36
Copy link
Contributor

@microamp microamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me. Just some minor comments.

k8s/ietfweb/nginx-default.conf Show resolved Hide resolved
k8s/ietfweb/supervisord.conf Show resolved Hide resolved
k8s/ietfweb/wagtail.yaml Show resolved Hide resolved
k8s/ietfweb/local.py Show resolved Hide resolved
k8s/ietfweb/local.py Show resolved Hide resolved
k8s/ietfweb/wagtail.yaml Show resolved Hide resolved
k8s/ietfweb/local.py Outdated Show resolved Hide resolved
k8s/ietfweb/local.py Show resolved Hide resolved
@microamp
Copy link
Contributor

microamp commented Jun 11, 2024

When possible, I'd like to see some documentation on how to run it locally - perhaps in a separate PR. Similar to https://github.com/ietf-tools/www/blob/feat/k8s/CONTRIBUTING.md#running-kubernetes-locally. Will add a new issue for that shortly.

@kesara
Copy link
Member Author

kesara commented Jun 11, 2024

When possible, I'd like to see some documentation on how to run it locally - perhaps in a separate PR. Similar to https://github.com/ietf-tools/www/blob/feat/k8s/CONTRIBUTING.md#running-kubernetes-locally. Will add a new issue for that shortly.

Not sure how valuable that is. It's hacky and the system depended on getting this running locally.
For usual development work, you should not run the k8s configuration.

k8s/ietfweb/wagtail.yaml Show resolved Hide resolved
@kesara kesara requested a review from NGPixel June 12, 2024 11:59
@kesara kesara merged commit aee9d29 into main Jun 17, 2024
5 checks passed
@kesara kesara deleted the feat/k8s branch June 17, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants