-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add www.ietf.org k8s configuration #453
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #453 +/- ##
===========================================
+ Coverage 82.81% 96.08% +13.27%
===========================================
Files 126 153 +27
Lines 2612 3293 +681
===========================================
+ Hits 2163 3164 +1001
+ Misses 449 129 -320 ☔ View full report in Codecov by Sentry. |
cba940d
to
ece5886
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay to me. Just some minor comments.
When possible, I'd like to see some documentation on how to run it locally - perhaps in a separate PR. Similar to https://github.com/ietf-tools/www/blob/feat/k8s/CONTRIBUTING.md#running-kubernetes-locally. Will add a new issue for that shortly. |
Not sure how valuable that is. It's hacky and the system depended on getting this running locally. |
No description provided.