refactor: Switch to a Debian base image #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
no objection |
kesara
reviewed
Dec 19, 2023
kesara
approved these changes
Dec 19, 2023
|
This change is breaking the dev instances: https://ws-main.dev.ietf.org/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #173, we're integrating the wagtail-ab-testing package, which unfortunately depends on numpy and scipy.
While numpy provides pre-compiled wheels for Alpine on both x86-64 and aarch64, scipy only provides alpine wheels for x86-64. This means people with newer ARM-based Macs (myself included) would have a hard time working on the project, either having to build and run the Docker image using emulation, or we'd have to modify the build process to compile scipy (which is both difficult and very slow).
Switching to Debian means we can use the scipy "manylinux" flavour of wheel, which is available for aarch64 too.