Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): Update heading styles #351

Merged
merged 9 commits into from
Dec 3, 2023
Merged

fix(css): Update heading styles #351

merged 9 commits into from
Dec 3, 2023

Conversation

JayDaley
Copy link
Contributor

@JayDaley JayDaley commented Dec 1, 2023

This is a set of changes to templates and SCSS to make the pages much more readable, by reducing vertical whitespace and reducing heading fonts sizes. The template changes are all replacing one bootstrap spacing class with another in various divs. Has been tested by Greg and is ready to go.

…348)

* fix(css): Reduce vertical whitespace

Reduce breadcrumb whitespace with mb-4 to mb-3 and pt-4 to pt-3.  Reduce intro text whitespace with pb-3 to pb-1.  Reduce body text whitespace with pt-lg-5 to pt-lg-3.  Reduce some right hand column whitespace with pt-4 to pt-3

* fix(css): Reduce font sizes on larger screens

Reduce font sizes from Bootstrap defaults with media selector min-width:1200px
Resize headers when they are inserted in the editor into a block-paragraph.
Resize headers when they appear inside a block-heading as as well as all the other special cases already handled.
Increase margin-bottom in unique block-heading class
Uses correct CSS this time for .block-paragraph and .block-heading
Move the css overrides directly to the end of main.scss as this is equivalent to where they will end up
Change font size and spacing for headings by directly editing existing settings
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (58b0bad) 82.54% compared to head (b0b7bdc) 82.53%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
- Coverage   82.54%   82.53%   -0.02%     
==========================================
  Files         112      112              
  Lines        2338     2336       -2     
==========================================
- Hits         1930     1928       -2     
  Misses        408      408              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kesara kesara changed the title Fix/css jay fix(css): Update heading styles Dec 3, 2023
@kesara kesara merged commit d388a19 into main Dec 3, 2023
7 checks passed
@kesara kesara deleted the fix/css-jay branch December 3, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants