-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(css): Update heading styles #351
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…348) * fix(css): Reduce vertical whitespace Reduce breadcrumb whitespace with mb-4 to mb-3 and pt-4 to pt-3. Reduce intro text whitespace with pb-3 to pb-1. Reduce body text whitespace with pt-lg-5 to pt-lg-3. Reduce some right hand column whitespace with pt-4 to pt-3 * fix(css): Reduce font sizes on larger screens Reduce font sizes from Bootstrap defaults with media selector min-width:1200px
Resize headers when they are inserted in the editor into a block-paragraph.
Resize headers when they appear inside a block-heading as as well as all the other special cases already handled.
Increase margin-bottom in unique block-heading class
Uses correct CSS this time for .block-paragraph and .block-heading
Move the css overrides directly to the end of main.scss as this is equivalent to where they will end up
Change font size and spacing for headings by directly editing existing settings
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
==========================================
- Coverage 82.54% 82.53% -0.02%
==========================================
Files 112 112
Lines 2338 2336 -2
==========================================
- Hits 1930 1928 -2
Misses 408 408 ☔ View full report in Codecov by Sentry. |
kesara
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a set of changes to templates and SCSS to make the pages much more readable, by reducing vertical whitespace and reducing heading fonts sizes. The template changes are all replacing one bootstrap spacing class with another in various divs. Has been tested by Greg and is ready to go.