fix: Improve developer experience #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Alow for more flexibility in database dump filenames - Fix indentation in the README Markdown - Use Django's `runserver` instead of gunicorn - Allow changing the port exposed by Docker - Specify the Node version in `.nvmrc` that matches the frontend Dockerfile
mgax
commented
Nov 27, 2023
docker/init-dev.sh
Outdated
| exec /usr/local/bin/gunicorn --config /app/docker/gunicorn.py --reload ietf.wsgi | ||
| exec ./manage.py runserver 0:8000 |
There was a problem hiding this comment.
For some reason, running the dev server with gunicorn leads to the server hanging for a few seconds every few requests. Django's native development server doesn't have this problem. It seems they both achieve the same result so I suggest we use Django's.
There was a problem hiding this comment.
I don't object to running runserver, but I am very uncomfortable walking away from a gunicorn problem here because we don't understand it. How do we know we won't have that problem in production?
There was a problem hiding this comment.
Fair point. I've undone the change until I can narrow down what's causing the issue.
mgax
commented
Nov 27, 2023
kesara
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Django'srunserverinstead of gunicorn.nvmrcthat matches the frontend Dockerfile