Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main bar color in dark mode not changing/too bright in userChrome-vibrancy.css #39

Open
semihcanturk opened this issue Apr 27, 2021 · 9 comments
Labels
bug Something isn't working

Comments

@semihcanturk
Copy link

When using userChrome-vibrancy.css in dark mode, the main bar seems to retain the light mode color while the other elements (search bar etc.) turn darker, and the text changes to white as expected. As a result, text becomes mostly illegible and dark mode is rendered useless:

Also see related discussion in #34.

@ideaweb
Copy link
Owner

ideaweb commented Apr 28, 2021

I checked it already, but not easy to find the trouble maker why vibrancy is broken. I removed already all the nodes and i am not able to get e.g. "-moz-appearance: -moz-mac-vibrancy-light" working just for the main window. Seems that something changes with recent final/stable version. I'll continue to check... but maybe someone has any idea what it could be.

@ideaweb ideaweb added the bug Something isn't working label Apr 28, 2021
@sarensabertooth
Copy link

sarensabertooth commented Jun 10, 2021

Having had issues since a few firefox updates ago, too. For me it looks like that in both light and dark mode.

@nchlscs
Copy link

nchlscs commented Jul 3, 2021

That's not theme's issue, firefox doesn't follow macos system appearance by default, setting widget.macos.respect-system-appearance to true fixes the problem.

@sarensabertooth
Copy link

That's not theme's issue, firefox doesn't follow macos system appearance by default, setting widget.macos.respect-system-appearance to true fixes the problem.

Issue persists for me

@nchlscs
Copy link

nchlscs commented Jul 8, 2021

Issue persists for me

macos 11, ff 89, the latest version of that style? Than, have no idea, userChrome-vibrancy.css with widget.macos.respect-system-appearance enabled works for me on two different macs in both light and dark mode.

@sarensabertooth
Copy link

sarensabertooth commented Jul 13, 2021

Issue persists for me

macos 11, ff 89, the latest version of that style? Than, have no idea, userChrome-vibrancy.css with widget.macos.respect-system-appearance enabled works for me on two different macs in both light and dark mode.

Same everything. When I change the theme inside firefox manually and then back to system, it all works as expected, also when switching system theme, but as soon as I restart the browser, I get that black bar and white icons on white background again, like OP.
Also it might be interesting, but when I use the userChrome without vibrancy, my firefox always starts up in dark mode! I think it has to do with that.

@sarensabertooth
Copy link

Ok so I had Firefox Colors (Official theme creator add-on) installed and that caused the issue. However, the issue still occurs when system is light mode and I want to switch to dark mode manually on firefox. Otherwise it works as expected now.

@ideaweb
Copy link
Owner

ideaweb commented May 13, 2022

I tried to fix vibrancy files. Please could you try again and let me know if its working for you?

@sarensabertooth
Copy link

I tried to fix vibrancy files. Please could you try again and let me know if its working for you?

All as expected, now. Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants