Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Validate" button? #102

Closed
traversaro opened this issue Jul 8, 2024 · 4 comments · Fixed by #108
Closed

Remove "Validate" button? #102

traversaro opened this issue Jul 8, 2024 · 4 comments · Fixed by #108
Assignees

Comments

@traversaro
Copy link
Member

Working with @DavideBarbone, I noticed it was a bit confusing to have a "Validate" button that does not work. If we are not using the button at the moment, could it make sense to just remove it?

@Nicogene
Copy link
Member

Nicogene commented Jul 8, 2024

This was a button that worked for simple assemblies but the validation it does is joint per joint and it is not feasible for complex assemblies. For the time being, we decided just to "disconnect" it, but if its presence is confusing we can remove it from the ribbon it should be trivial

@traversaro
Copy link
Member Author

traversaro commented Jul 8, 2024

What is the advantage of "disconnecting" it as opposed to just remove it? At least from the GUI, then the code can still be there, but at least it does not confuse new users.

@Nicogene
Copy link
Member

Nicogene commented Jul 9, 2024

What is the advantage of "disconnecting" it as opposed to just remove it? At least from the GUI, then the code can still be there, but at least it does not confuse new users.

Totally agree, it has probably been done to remove it quickly

@Nicogene
Copy link
Member

Fixed by #108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants