Add approve all option

icodesign · Aug 31, 2024 · c2ffebc · c2ffebc
1 parent 544aec0
commit c2ffebc
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/packages/translate/src/entity.ts b/packages/translate/src/entity.ts
@@ -159,7 +159,7 @@ export function convertXliffsToEntities(
       throw new Error(`Cannot merge file without target language.`);
     }
     for (const file of xliff.elements || []) {
-      const startKeys = [sourceLanguage, targetLanguage, file.attributes.id];
+      const startKeys = [file.attributes.id];
       for (const element of file.elements || []) {
         const entities = convertXliffElementToEntities(
           element,

diff --git a/packages/translate/src/index.ts b/packages/translate/src/index.ts
@@ -217,7 +217,8 @@ async function translateStrings(
       var approved = 0;
       var declined = 0;
       var refineNeeded = 0;
-      for (const entity of translations) {
+      for (let index = 0; index < translations.length; index++) {
+        const entity = translations[index];
         if (entity.needsReview) {
           logger.info(
             `Skip reviewing ${entity.key} because all target languages are skipped.`,
@@ -269,6 +270,11 @@ async function translateStrings(
                 value: LOCALITION_REVIEW_SUBSTATE_DECLINED,
                 description: 'The translation will be discarded',
               },
+              {
+                name: 'Approve All',
+                value: 'approveAll',
+                description: 'Skip reviewing all translations for this string',
+              },
             ],
           },
           {
@@ -298,6 +304,10 @@ async function translateStrings(
           entity.addNotes([auditSuggestion]);
           remainings.push(entity);
           refineNeeded += 1;
+        } else if (reviewResult === 'approveAll') {
+          reviewed.push(...translations.slice(index));
+          approved += translations.length - index;
+          break;
         }
       }