Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Data.Monoid newtypes #121

Open
jacobstanley opened this issue Dec 17, 2016 · 3 comments
Open

Remove Data.Monoid newtypes #121

jacobstanley opened this issue Dec 17, 2016 · 3 comments

Comments

@jacobstanley
Copy link
Contributor

Any, All, First, Last, Sum, and Product are all useful type/constructor names and it's very rare that I would use the newtype instead of just calling the function of the same name.

The only times that I've ever referred to these things in P is when I have to hide them so I can use the name for one of my own types/constructors.

Have other people found the same thing?

I would like to propose removing them and freeing up the names.

This will be a breaking change that will cause a little bit of churn, for one thing all the places where I have:

import P hiding (All) -- etc
@jacobstanley
Copy link
Contributor Author

jacobstanley commented Dec 17, 2016

Could be done at the same time as #74 if people agree

@thumphries
Copy link
Contributor

Do we actually use these anywhere? I didn't know they existed. Would be good to estimate the churn before pulling the trigger

@jacobstanley
Copy link
Contributor Author

Look at the code on my disk the only churn for projects I have would be removing the hiding (XYZ) clauses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants