Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA - Errors on submitted data pages are not sorted to the top of list #2624

Open
edsu7 opened this issue Apr 3, 2023 · 2 comments
Open

QA - Errors on submitted data pages are not sorted to the top of list #2624

edsu7 opened this issue Apr 3, 2023 · 2 comments
Assignees

Comments

@edsu7
Copy link

edsu7 commented Apr 3, 2023

Errors are not auto-sorted to appear as first instances of page.

For example:
image

Tab indicates errors are found but do not appear in first page. Have to skip to page three:
image

@demariadaniel demariadaniel self-assigned this Apr 11, 2024
@demariadaniel
Copy link
Contributor

Before:
Screenshot 2024-04-11 at 4.35.49 PM.png

After:
Screenshot 2024-04-11 at 4.36.51 PM.png

@demariadaniel
Copy link
Contributor

demariadaniel commented Apr 29, 2024

Additional Clinical service changes in: icgc-argo/argo-clinical#1184

Argo Dev current state:
Screenshot 2024-04-29 at 2.12.21 PM.png

Argo Dev data w/ Clinical and UI changes
Screenshot 2024-04-29 at 2.12.54 PM.png

Note that because records are grouped by Donor, not ALL error records show in the first 20 results (because some donors have multiple records, some valid, some not valid)

However with Clinical changes we've insured that invalid donors are prioritized, so you do see Donors with errors first and will see more error results when the page size is expanded (screenshot #3 shows results when page size is 100 records)

Screenshot 2024-04-29 at 2.16.18 PM.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants