Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect/Login #176

Open
rosibaj opened this issue Jun 30, 2021 · 4 comments
Open

Redirect/Login #176

rosibaj opened this issue Jun 30, 2021 · 4 comments

Comments

@rosibaj
Copy link
Contributor

rosibaj commented Jun 30, 2021

When you are taken to a URL and arent logged in

  • direct the user to login
  • after login the user should be taken to the original page
@samrichca
Copy link
Contributor

samrichca commented Jul 15, 2021

image

image

TL;DR: URL params are the blocker, so we could ignore them for login redirects. Users would be redirected to the application but not a specific page of the application.

Debugging note: In the browser console turn on preserve logs or you'll never see some of the console logs.

https://github.com/icgc-argo/dac-ui/compare/feat/login-redirect-3

@akachru-github
Copy link

  • Emails deep link to application, we will need to direct users to login and take them to their original destination.
  • Note: due to routing issues, we cannot deep link to a specific section of the application, only to the first page of the application.

@samrichca
Copy link
Contributor

samrichca commented Aug 18, 2021

#374

pausing this for now to decide how to proceed with loading

@b-f-chan
Copy link

b-f-chan commented Apr 4, 2023

Icebox and do in refactoring for Overture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants