Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Test Coverage to Check Notes and Spans #623

Open
InsertCreativityHere opened this issue Jun 28, 2023 · 0 comments
Open

Extend Test Coverage to Check Notes and Spans #623

InsertCreativityHere opened this issue Jun 28, 2023 · 0 comments
Labels
proposal task testing Adding or modifying tests
Milestone

Comments

@InsertCreativityHere
Copy link
Member

Currently, most of our tests only check that the message/fields of a diagnostic are correct,
and neglect to check any additional context stored by the diagnostic (span, scope, or notes).

Testing these pieces of 'extra' information definitely isn't as important as testing the diagnostic's field & message,
but are probably worth testing none-the-less; otherwise we may be emitting bogus notes or incorrect snippets.

@InsertCreativityHere InsertCreativityHere added this to the 0.2 milestone Jun 28, 2023
@InsertCreativityHere InsertCreativityHere modified the milestones: 0.2, Future Sep 19, 2023
@InsertCreativityHere InsertCreativityHere added proposal testing Adding or modifying tests task labels Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal task testing Adding or modifying tests
Projects
None yet
Development

No branches or pull requests

1 participant