Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Theme #1

Open
lefoy opened this issue Jul 8, 2014 · 14 comments
Open

Dark Theme #1

lefoy opened this issue Jul 8, 2014 · 14 comments

Comments

@lefoy
Copy link

lefoy commented Jul 8, 2014

Very nice job with this theme! I like it a lot. Do you plan to make a dark theme variant? :)

@iccir
Copy link
Owner

iccir commented Jul 8, 2014

I think it will depend on what Apple does in 10.10. If Dark Mode affects both apps and the menu bar / dock, it makes sense to make a theme that matches the system. If Dark Mode doesn't affect apps, then an El Capitan Dark theme is going to clash with the window's white title bar.

@lefoy
Copy link
Author

lefoy commented Jul 8, 2014

According to Techcrunch, it does affect apps and dock.

9to5Mac has screens of the dark mode in action, and it’s beautiful to behold. The feature likely won’t even be appreciated by most, but it’s something that could actually affect the user experience more than you might think, since it applies not only to the Mac’s persistent menu bar but also to the top bar that appears on each app window and the dock background.

http://techcrunch.com/2014/07/07/mac-os-x-gets-the-dark-theme-weve-all-been-waiting-for-in-yosemite-preview-3/

@fregante
Copy link

fregante commented Jul 8, 2014

It's been clashing with the gray title bar for a while, it's not a big deal.

screen shot 2014-07-08 at 04 12 54

Nice job on the white theme ^_^

@soldni
Copy link

soldni commented Jul 23, 2014

I second this. I have always been a huge fan of dark interfaces!

@NorthIsUp
Copy link

+1

@NorthIsUp
Copy link

any progress on deciding if this will be supported?

@iccir
Copy link
Owner

iccir commented Aug 18, 2014

Honestly, I'm unlikely to support a dark theme soon (I'm bogged down with other work at the moment). But the source file for all image assets is in the Source directory, if anybody wants to fork and make :)

@r3volution11
Copy link

I may take you up on that and work on a dark theme. I actually started messing with Soda to do so the other day and then found this. So that helps a lot. Great work btw!

@r3volution11
Copy link

iccir, I've followed through and started working on a dark theme: https://github.com/r3volution11/El-Capitan-Theme

Should I create a new name for the dark option?

@iccir
Copy link
Owner

iccir commented Sep 13, 2014

Sweet! Looks nice!

I think it makes sense to create a new name / package for the Dark option. Honestly, I've never understood why Soda Theme et. al use one package for two themes (since each theme needs it's own .sublime-theme file anyway. Unless I'm missing something obvious? ;) )

@r3volution11
Copy link

Great! I've been AFK for a few days but when I get back I want to create a template in Sketch for the theme before moving forward. I was doing it piece by piece at first thinking I could knock it out pretty quickly but obviously that has its issues.

Sounds good about the new name. I could stick to the Yosemite landmark naming scheme and go with Sentinel Dome; think that sounds good? 

The only reason I can think of to keep the theme the same name/package is for brand recognition and making it easier to find. But really anyone with Sublime Text that wants to change their theme can find new ones easily thanks to package manager and its repository.

Thanks for responding. I've been wanting to work on a theme for a while and am pumped to get this released!

Thanks,
Doug C. Hardester

On September 12, 2014 at 9:11:34 PM, Ricci Adams ([email protected]) wrote:

Sweet! Looks nice!

I think it makes sense to create a new name / package for the Dark option. Honestly, I've never understood why Soda Theme et. al use one package for two themes (since each theme needs it's own .sublime-theme file anyway. Unless I'm missing something obvious? ;) )


Reply to this email directly or view it on GitHub.

@iccir
Copy link
Owner

iccir commented Sep 28, 2014

Ack! I just saw this, please excuse the delay.

Sentinel Dome sounds great :) Let me know the final GitHub repository for it and I'll update the link in the README

@r3volution11
Copy link

Hey Ricci,

Thanks for getting back to me. I'll let you know as soon as I get it going!

-- 

Thanks,

Doug C. Hardester

On September 28, 2014 at 12:37:00 AM, Ricci Adams ([email protected]) wrote:

Ack! I just saw this, please excuse the delay.

Sentinel Dome sounds great :) Let me know the final GitHub repository for it and I'll update the link in the README


Reply to this email directly or view it on GitHub.

@kopiro
Copy link

kopiro commented Oct 28, 2014

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants