diff --git a/releasenotes.md b/releasenotes.md index 761157ab9..9ee93e322 100644 --- a/releasenotes.md +++ b/releasenotes.md @@ -15,6 +15,8 @@ Released on xx/xx/xxxx. - Add a new directory ``/baselines``, containing baseline testing scripts and associated KPI results for the baseline controllers of all the testcases. This is for [#495](https://github.com/ibpsa/project1-boptest/issues/495). - Add support to ``parsing/parser.py`` for test case compilation using [Modelon's OPTIMICA Compiler Toolkit (OCT)](https://help.modelon.com/latest/reference/oct/). The parser can take arguments ``'JModelica'`` or ``'OCT'``, with ``'JModelica'`` as default. A user still requires access to an OCT license and software on their set up. This is for [#675](https://github.com/ibpsa/project1-boptest/issues/675). - Changed ``bestest_hydronic`` and ``bestest_hydronic_heat_pump`` Modelica implementations in this repository to utilize the Modelica IDEAS Library as a dependency for component models, instead of serving as extensions from the Modelica IDEAS Library. This is to simplify dependencies for maintaining the models, and is how other test cases are implemented. It required duplication of the model implementations from the Modelica IDEAS Library into this repository. This is for [#680](https://github.com/ibpsa/project1-boptest/issues/680). +- Add ``activate`` control inputs that were missing in ``bestest_hydronic`` and ``bestest_hydronic_heat_pump`` Modelica documentation. This is for [#625](https://github.com/ibpsa/project1-boptest/issues/625). + **The following new test cases have been added:** @@ -24,6 +26,7 @@ Released on xx/xx/xxxx. **The following changes are backwards-compatible, but might change benchmark results:** - Fix calculation of computational time ratio (``time_rat``) in the case of a test where the test case was initialized after a test or simulation (use of ``/advance``) had already been done using the same test case deployment (i.e. the docker container had not been shutdown first and newly deployed). The wait time between the last ``/advance`` before the new initialization and first ``/advance`` of the new initialization was incorrectly incorporated into the calculation as a control step and has been fixed, resulting in a lower computational time ratio. The extent of impact depends on wait time between tests and control step and number of steps taken in the new test. This is for [#673](https://github.com/ibpsa/project1-boptest/issues/673). + - Update ``min`` and ``max`` parameters for heating (``oveTSetHea_u``) and cooling (``oveTSetCoo_u``) setpoints in ``bestest_air`` and ``bestest_hydronic`` test cases to ``min=278.15`` and ``max=308.15``. This may change benchmark results as it expands the allowable min and max set points for these test cases from previous versions. This is for [#658](https://github.com/ibpsa/project1-boptest/issues/658). **The following changes are not backwards-compatible and significantly change benchmark results:** diff --git a/testcases/bestest_air/doc/index.html b/testcases/bestest_air/doc/index.html index 572618d62..d012e4f4c 100644 --- a/testcases/bestest_air/doc/index.html +++ b/testcases/bestest_air/doc/index.html @@ -266,13 +266,13 @@

Inputs

con_oveTSetCoo_activate [1] [min=0, max=1]: Activation signal to overwrite input con_oveTSetCoo_u where 1 activates, 0 deactivates (default value)
  • -con_oveTSetCoo_u [K] [min=296.15, max=303.15]: Zone temperature setpoint for cooling +con_oveTSetCoo_u [K] [min=278.15, max=308.15]: Zone temperature setpoint for cooling
  • con_oveTSetHea_activate [1] [min=0, max=1]: Activation signal to overwrite input con_oveTSetHea_u where 1 activates, 0 deactivates (default value)
  • -con_oveTSetHea_u [K] [min=288.15, max=296.15]: Zone temperature setpoint for heating +con_oveTSetHea_u [K] [min=278.15, max=308.15]: Zone temperature setpoint for heating
  • fcu_oveFan_activate [1] [min=0, max=1]: Activation signal to overwrite input fcu_oveFan_u where 1 activates, 0 deactivates (default value) diff --git a/testcases/bestest_air/models/BESTESTAir/BaseClasses/Thermostat_T.mo b/testcases/bestest_air/models/BESTESTAir/BaseClasses/Thermostat_T.mo index 23686b274..ec16d408e 100644 --- a/testcases/bestest_air/models/BESTESTAir/BaseClasses/Thermostat_T.mo +++ b/testcases/bestest_air/models/BESTESTAir/BaseClasses/Thermostat_T.mo @@ -31,8 +31,8 @@ model Thermostat_T Buildings.Utilities.IO.SignalExchange.Overwrite oveTSetCoo(u( unit="K", - min=273.15 + 23, - max=273.15 + 30), description="Zone temperature setpoint for cooling") + min=273.15 + 5, + max=273.15 + 35), description="Zone temperature setpoint for cooling") "Overwrite for zone cooling setpoint" annotation (Placement(transformation(extent={{-70,70},{-50,90}}))); Modelica.Blocks.Sources.CombiTimeTable TSetCoo( @@ -43,9 +43,9 @@ model Thermostat_T annotation (Placement(transformation(extent={{-100,70},{-80,90}}))); Buildings.Utilities.IO.SignalExchange.Overwrite oveTSetHea(description="Zone temperature setpoint for heating", u( - max=273.15 + 23, + max=273.15 + 35, unit="K", - min=273.15 + 15)) "Overwrite for zone heating setpoint" + min=273.15 + 5)) "Overwrite for zone heating setpoint" annotation (Placement(transformation(extent={{-70,30},{-50,50}}))); Modelica.Blocks.Sources.CombiTimeTable TSetHea( smoothness=Modelica.Blocks.Types.Smoothness.ConstantSegments, diff --git a/testcases/bestest_air/models/BESTESTAir/TestCases/TestCase_Ideal.mo b/testcases/bestest_air/models/BESTESTAir/TestCases/TestCase_Ideal.mo index ea1ca4e43..6dc5ef155 100644 --- a/testcases/bestest_air/models/BESTESTAir/TestCases/TestCase_Ideal.mo +++ b/testcases/bestest_air/models/BESTESTAir/TestCases/TestCase_Ideal.mo @@ -1,4 +1,4 @@ -within BESTESTAir.TestCases; +within BESTESTAir.TestCases; model TestCase_Ideal "Testcase model with ideal airflow" extends Modelica.Icons.Example; BaseClasses.Case900FF zon(mAir_flow_nominal=fcu.mAir_flow_nominal) @@ -294,13 +294,13 @@ The model inputs are: con_oveTSetCoo_activate [1] [min=0, max=1]: Activation signal to overwrite input con_oveTSetCoo_u where 1 activates, 0 deactivates (default value)
  • -con_oveTSetCoo_u [K] [min=296.15, max=303.15]: Zone temperature setpoint for cooling +con_oveTSetCoo_u [K] [min=278.15, max=308.15]: Zone temperature setpoint for cooling
  • con_oveTSetHea_activate [1] [min=0, max=1]: Activation signal to overwrite input con_oveTSetHea_u where 1 activates, 0 deactivates (default value)
  • -con_oveTSetHea_u [K] [min=288.15, max=296.15]: Zone temperature setpoint for heating +con_oveTSetHea_u [K] [min=278.15, max=308.15]: Zone temperature setpoint for heating
  • fcu_oveFan_activate [1] [min=0, max=1]: Activation signal to overwrite input fcu_oveFan_u where 1 activates, 0 deactivates (default value) @@ -769,6 +769,12 @@ see https://www.eia.gov/environment/emissions/co2_vol_mass.php. revisions="