-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue1913 remove sta t #1918
Issue1913 remove sta t #1918
Conversation
Converted PR to draft. |
…fier to add two port sensors
Converted to draft again to work on the following additional models:
They were missed in the |
IBPSA$ sed -i -E 's/replace <code>sta_\?\.T/replace <code>sta_*.T/g' $(find . -iname '*.mo')
@jelgerjansen : Can you please review this so that we have a non-LBNL reviewer. This change is needed due to allow verification across different Modelica tools. See lbl-srg/modelica-buildings#3957 for the reason and discussions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hcasperfu the changes look good to me. I only have a minor comment regarding the naming of temperature sensors at the inlet of a component. If you want to keep the current naming, that's fine by me (and then I'll approve).
IBPSA/Fluid/Interfaces/Examples/BaseClasses/PrescribedOutletState.mo
Outdated
Show resolved
Hide resolved
IBPSA/Fluid/Interfaces/Examples/BaseClasses/PrescribedOutletState.mo
Outdated
Show resolved
Hide resolved
IBPSA/Fluid/Interfaces/Examples/BaseClasses/PrescribedOutletState.mo
Outdated
Show resolved
Hide resolved
IBPSA/Fluid/Interfaces/Examples/BaseClasses/PrescribedOutletState.mo
Outdated
Show resolved
Hide resolved
@jelgerjansen - |
This closes #1913.
The models that have
sta_?.T
in their reference results:Fluid.HeatExchangers.Radiators.Examples.RadiatorEN442_2
Fluid.FixedResistances.Validation.LosslessPipe
Examples.{SimpleHouse,Tutorial.SimpleHouse.SimpleHouse6}
TemperatureTwoPort
components to replacesta_?.T
.Fluid.Interfaces.Examples.{PrescribedOutlet,PrescribedOutlet_TSetOnly,PrescribedOutlet_Water,PrescribedOutlet_X_wSetOnly}
TemperatureTwoPort
to base classIBPSA.Fluid.Interfaces.Examples.BaseClasses.PrescribedOutletState
.Fluid.SolarCollectors.Validation.{EN12975_Array,EN12975_Series}
Fluid.Humidifiers.Validation.{SteamHumidifier_X_dynamic,SprayAirWasher_X,SteamHumidifier_X,SprayAirWasher_X_dynamic}
Fluid.Interfaces.Examples.{ConservationEquation,StaticTwoPortConservationEquation}
Fluid.Interfaces.Examples.Humidifier_u
Fluid.Geothermal.Borefields.Examples.RectangularBorefield
allowFlowReversal==false
.