Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1913 remove sta t #1918

Merged
merged 23 commits into from
Aug 18, 2024
Merged

Issue1913 remove sta t #1918

merged 23 commits into from
Aug 18, 2024

Conversation

hcasperfu
Copy link
Contributor

@hcasperfu hcasperfu commented Aug 6, 2024

This closes #1913.

The models that have sta_?.T in their reference results:

Fluid.HeatExchangers.Radiators.Examples.RadiatorEN442_2
Fluid.FixedResistances.Validation.LosslessPipe
Examples.{SimpleHouse,Tutorial.SimpleHouse.SimpleHouse6}

  • Added TemperatureTwoPort components to replace sta_?.T.

Fluid.Interfaces.Examples.{PrescribedOutlet,PrescribedOutlet_TSetOnly,PrescribedOutlet_Water,PrescribedOutlet_X_wSetOnly}

  • Added TemperatureTwoPort to base class IBPSA.Fluid.Interfaces.Examples.BaseClasses.PrescribedOutletState.

Fluid.SolarCollectors.Validation.{EN12975_Array,EN12975_Series}
Fluid.Humidifiers.Validation.{SteamHumidifier_X_dynamic,SprayAirWasher_X,SteamHumidifier_X,SprayAirWasher_X_dynamic}
Fluid.Interfaces.Examples.{ConservationEquation,StaticTwoPortConservationEquation}
Fluid.Interfaces.Examples.Humidifier_u

  • No action. Flow rate is constant.

Fluid.Geothermal.Borefields.Examples.RectangularBorefield

  • No action because allowFlowReversal==false.

@hcasperfu hcasperfu requested a review from mwetter August 6, 2024 16:47
@hcasperfu hcasperfu self-assigned this Aug 6, 2024
@hcasperfu hcasperfu marked this pull request as draft August 7, 2024 18:27
@hcasperfu
Copy link
Contributor Author

Converted PR to draft.
Fluid.Interfaces.Examples.Humidifier_u is in the list in OpenModelica/OpenModelica#12704 and I need more time to think about what to do with it.

@hcasperfu hcasperfu marked this pull request as draft August 8, 2024 23:24
@hcasperfu
Copy link
Contributor Author

Converted to draft again to work on the following additional models:

  • Fluid.Chillers.Validation.Carnot_TEva_reverseFlow
  • Fluid.HeatExchangers.Validation.ConstantEffectiveness
  • Fluid.HeatPumps.Validation.Carnot_TCon_reverseFlow

They were missed in the grep because variable names with the regex form sta_..\.T (such as sta_a1.T) were not considered.

@hcasperfu hcasperfu marked this pull request as ready for review August 10, 2024 14:54
IBPSA$ sed -i -E 's/replace <code>sta_\?\.T/replace <code>sta_*.T/g' $(find . -iname '*.mo')
@mwetter
Copy link
Contributor

mwetter commented Aug 15, 2024

@jelgerjansen : Can you please review this so that we have a non-LBNL reviewer. This change is needed due to allow verification across different Modelica tools. See lbl-srg/modelica-buildings#3957 for the reason and discussions.

Copy link
Contributor

@jelgerjansen jelgerjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hcasperfu the changes look good to me. I only have a minor comment regarding the naming of temperature sensors at the inlet of a component. If you want to keep the current naming, that's fine by me (and then I'll approve).

@hcasperfu
Copy link
Contributor Author

@jelgerjansen -
Greetings and thanks for the review!
I changed the variable names as suggested except for the chiller/HP models. Personally I think "entering" and "leaving" temperatures are more commonly used than "in" or "out" in these contexts. An example in the library is IBPSA.Fluid.Chillers.Examples.Carnot_TEva, although it is not for a temperature sensor.

@hcasperfu hcasperfu merged commit a776e41 into master Aug 18, 2024
3 checks passed
@hcasperfu hcasperfu deleted the issue1913_removeStaT branch August 18, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove or replace sta_?.T from reference results
3 participants