-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create tutorial for use at Modelica Conference #1785
Comments
@jelgerjansen : thanks for the PR, which I moved to a development branch. The development branch is Can you please address the following.
I have not yet reviewed the pdf documentation. |
Thank you for your comments @mwetter! For the regression test I based myself on the script of The description I added are very short since the actual documentation can be found in the pdf itself. If desired, we could also move the information in the pdf to the Info section of the model itself? Please let me know if there is still something to be changed. |
@jelgerjansen : Thanks for the changes. Running the unit tests should indeed work by following the steps at the above link that you provided. Is something not working? You can see the BuildingsPy version here: Line 23 in 5766402
That commit is essentially the same as v5.0.0 that was released last Friday.
If you could move the information from the pdf document to the info section, that would be fantastic. This way, all documentation is together, and online library documentation (either through the tool or on the web page such as https://build.openmodelica.org/Documentation/IBPSA.Fluid.Examples.html) will have all documentation accessible without having to post the pdf somewhere separate. -- This would also remove the issue that the pdf has the CC license, but IBPSA authorized developing the library under BSD, so we would need to figure out how to address that. (It is also easier for others to integrate the library if there is only one single license, so avoiding mix of licenses is IMHO important.) One small item I found was that Figure 5 lists |
@mwetter I removed the pdf and added the exercises to the information section of the different models. Now I am able to run the unit tests, but they seem to take forever on my pc, so I didn't add the new reference results yet... |
@jelgerjansen : Thanks for the changes. They look good. I added the reference results and also updated the instructions for how to run the unit tests. I removed the text As the tutorial also includes modeling of weather data, heat transfer and controls, in addition to fluid modeling, I think it would actually be better placed in Through a separate issue I can then also move |
@mwetter thank you for updating the reference results and the documentation for running the unit tests! I agree with moving the SimpleHouse tutorial to I furthermore agree with moving |
@jelgerjansen : It would be great if you can update the documentation in |
This issue is to create a tutorial for the Modelica Conference, including a development branch for #1783
The text was updated successfully, but these errors were encountered: