From f4fac7b5e0d0d79c133e10b3bb81eaa2981b3331 Mon Sep 17 00:00:00 2001 From: "fabian.wuellhorst" Date: Mon, 13 May 2024 10:22:38 +0200 Subject: [PATCH 01/12] group safety control parameters according to dialog enable --- .../ModularReversible/Controls/Safety/Data/Generic.mo | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/IBPSA/Fluid/HeatPumps/ModularReversible/Controls/Safety/Data/Generic.mo b/IBPSA/Fluid/HeatPumps/ModularReversible/Controls/Safety/Data/Generic.mo index 15df85ee00..66fbcc164d 100644 --- a/IBPSA/Fluid/HeatPumps/ModularReversible/Controls/Safety/Data/Generic.mo +++ b/IBPSA/Fluid/HeatPumps/ModularReversible/Controls/Safety/Data/Generic.mo @@ -7,6 +7,11 @@ record Generic "Generic record definition for safety control blocks" parameter Modelica.Units.SI.Time minOnTime "Mimimum on-time" annotation (Dialog(group= "On/Off Control", enable=use_minOnTime)); + parameter Real ySetRed(unit="1") + "Reduced relative compressor speed to allow longer on-time" + annotation ( + Dialog(group="On/Off Control", + enable=use_minOnTime)); parameter Boolean use_minOffTime "=false to ignore minimum off time" annotation (Dialog(group="On/Off Control"), @@ -21,11 +26,7 @@ record Generic "Generic record definition for safety control blocks" parameter Integer maxCycRat "Maximum cycle rate" annotation (Dialog(group="On/Off Control", enable=use_maxCycRat)); - parameter Real ySetRed(unit="1") - "Reduced relative compressor speed to allow longer on-time" - annotation ( - Dialog(group="On/Off Control", - enable=use_minOnTime)); + parameter Boolean onOffMea_start=true "Start value for the on-off signal of the device, true for on" annotation ( From 1bb7734235850e99036d75f1847767763d98b49e Mon Sep 17 00:00:00 2001 From: "fabian.wuellhorst" Date: Mon, 13 May 2024 10:26:48 +0200 Subject: [PATCH 02/12] add name to contributor list --- IBPSA/package.mo | 3 +++ 1 file changed, 3 insertions(+) diff --git a/IBPSA/package.mo b/IBPSA/package.mo index e776a051d5..e349000bd7 100644 --- a/IBPSA/package.mo +++ b/IBPSA/package.mo @@ -333,6 +333,9 @@ Kathryn Hinkelman, University of Colorado Boulder, USA
  • Michael Wetter, Lawrence Berkeley National Laboratory, Berkeley, CA, USA
  • +
  • +Fabian Wuellhorst, RWTH Aachen University, Germany +
  • ")); end Acknowledgements; From b4fd3e8a9419bbcb55d1c95c30e9012ed19f6218 Mon Sep 17 00:00:00 2001 From: "fabian.wuellhorst" Date: Mon, 13 May 2024 10:28:34 +0200 Subject: [PATCH 03/12] Change over- to undersizing and update documentation of the example --- .../Examples/AirToWater2D_OneRoomRadiator.mo | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/IBPSA/Fluid/HeatPumps/ModularReversible/Examples/AirToWater2D_OneRoomRadiator.mo b/IBPSA/Fluid/HeatPumps/ModularReversible/Examples/AirToWater2D_OneRoomRadiator.mo index a03b6a0674..2300507740 100644 --- a/IBPSA/Fluid/HeatPumps/ModularReversible/Examples/AirToWater2D_OneRoomRadiator.mo +++ b/IBPSA/Fluid/HeatPumps/ModularReversible/Examples/AirToWater2D_OneRoomRadiator.mo @@ -21,7 +21,7 @@ model AirToWater2D_OneRoomRadiator dpCon_nominal(displayUnit="Pa") = 2000, dpEva_nominal(displayUnit="Pa") = 200, energyDynamics=Modelica.Fluid.Types.Dynamics.FixedInitial, - QCoo_flow_nominal=-20000, + QCoo_flow_nominal=-10000, TConHea_nominal=rad.TRad_nominal, TEvaHea_nominal=283.15, TConCoo_nominal=oneRooRadHeaPumCtr.TRadMinSup, @@ -87,6 +87,16 @@ equation heat pump model. Please check the associated documentation for further information.

    +

    + Furthermore, this example is useful to understand the different sizing options. + The selected value of QCoo_flow_nominal leads to + conflicting scaling factors for heating and cooling operation. This triggers a warning. + Using the default QCoo_flow_nominal, the warning disappears. + Increasing (or decreasing) it, the number of on-off switches will increase (or decrease) + in cooling operation due to the low inertia of the system. + In real air-to-water systems, thermal energy storage would be used to + decrease cycling if the device is oversized. +

    Please check the documentation of @@ -95,6 +105,11 @@ equation

    ", revisions="