From 2cbf89bc85f488feb77302f8b60832009359f646 Mon Sep 17 00:00:00 2001
From: "fabian.wuellhorst" <fabian.wuellhorst@eonerc.rwth-aachen.de>
Date: Mon, 15 Jul 2024 12:32:13 +0200
Subject: [PATCH] fix hysteresis values to avoid difference in simulation when
 comparing dymola to OM

---
 .../BaseClasses/PartialReversibleRefrigerantMachine.mo        | 4 ++--
 .../Examples/BaseClasses/OneRoomRadiatorHeatPumpControl.mo    | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/IBPSA/Fluid/HeatPumps/ModularReversible/BaseClasses/PartialReversibleRefrigerantMachine.mo b/IBPSA/Fluid/HeatPumps/ModularReversible/BaseClasses/PartialReversibleRefrigerantMachine.mo
index b0dac8e538..2932eb8209 100644
--- a/IBPSA/Fluid/HeatPumps/ModularReversible/BaseClasses/PartialReversibleRefrigerantMachine.mo
+++ b/IBPSA/Fluid/HeatPumps/ModularReversible/BaseClasses/PartialReversibleRefrigerantMachine.mo
@@ -201,7 +201,7 @@ partial model PartialReversibleRefrigerantMachine
   parameter Boolean linearized=false
     "= true, use linear relation between m_flow and dp for any flow rate"
     annotation (Dialog(tab="Advanced", group="Flow resistance"));
-  parameter Real ySet_small=0.01
+  parameter Real ySet_small(min=0.002)=0.01
     "Threshold for relative speed for the device to be considered on"
     annotation (Dialog(tab="Advanced", group="Diagnostics"));
   parameter Boolean calEff=true
@@ -315,7 +315,7 @@ partial model PartialReversibleRefrigerantMachine
         rotation=0)));
 
   Modelica.Blocks.Logical.Hysteresis hys(
-    final uLow=Modelica.Constants.eps,
+    final uLow=0.001,
     final uHigh=ySet_small,
     final pre_y_start=false) "Use default ySet value" annotation (Placement(
         transformation(extent={{10,10},{-10,-10}}, rotation=180,
diff --git a/IBPSA/Fluid/HeatPumps/ModularReversible/Examples/BaseClasses/OneRoomRadiatorHeatPumpControl.mo b/IBPSA/Fluid/HeatPumps/ModularReversible/Examples/BaseClasses/OneRoomRadiatorHeatPumpControl.mo
index d4a3eb63c0..5edf5a64fb 100644
--- a/IBPSA/Fluid/HeatPumps/ModularReversible/Examples/BaseClasses/OneRoomRadiatorHeatPumpControl.mo
+++ b/IBPSA/Fluid/HeatPumps/ModularReversible/Examples/BaseClasses/OneRoomRadiatorHeatPumpControl.mo
@@ -1,4 +1,4 @@
-within IBPSA.Fluid.HeatPumps.ModularReversible.Examples.BaseClasses;
+within IBPSA.Fluid.HeatPumps.ModularReversible.Examples.BaseClasses;
 model OneRoomRadiatorHeatPumpControl
   "Helper model for the control of the system"
   parameter Boolean witCoo=true
@@ -77,7 +77,7 @@ model OneRoomRadiatorHeatPumpControl
         origin={90,-10})));
   Modelica.Blocks.Logical.Hysteresis hysSecCoo(
     final uLow=TRadMinSup,
-    final uHigh=TRadMinSup + 1,
+    final uHigh=TRadMinSup + 4,
     final pre_y_start=false)
             if witCoo
     "Hysteresis for avoiding temperatures below 15 °C when cooling"