fn_joe_sandbox_analysis - app_config proxy settings not applied

[fhubaer]

Description

• When configuring a proxy only via the app_config jsb_* keys, the proxy is not used.

Describe How to Reproduce

• Configure proxies in the app_config.
• Only set the proxy in the apps jsb_http_proxy and jsb_https_proxy keys, not globally.
• Block outgoing connections from the AppHost to *:443.
• Run a configuration test, recieve an error and discover that the server-alive-check fails.
• Watch your AppHost connections with tcpdump or your firewall logs and discover that the app attempts direct connections instead of using the proxy.

Possible cause

See the proxy selection code in

• https://github.com/ibmresilient/resilient-community-apps/blob/master/fn_joe_sandbox_analysis/fn_joe_sandbox_analysis/util/selftest.py and in
• https://github.com/ibmresilient/resilient-community-apps/blob/master/fn_joe_sandbox_analysis/fn_joe_sandbox_analysis/components/fn_joe_sandbox_analysis.py

    try:
        proxies = get_proxies(opts, app_configs)
        if (HTTP_PROXY) and (len(proxies) == 0):
            proxies["http"] = HTTP_PROXY
                
        if (HTTPS_PROXY) and (len(proxies) == 0):
            proxies["https"] = HTTPS_PROXY
                
        if (len(proxies) == 0):
            proxies = None
    except Exception as proxy_error:
        proxies = None

• I guess get_proxies(...) returns None in my scenario, len(proxies) raises TypeError and the jsb_* values are never set.
• Furthermore, wouldn't this code only set the jsb_* values when there are no global proxies configured? Shouldn't it be the opposite?
• And last, wouldn't this only ever set the proxy for one protocol?