Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off the Default Bucket in COS class #32

Open
bassel-zeidan opened this issue Oct 9, 2017 · 1 comment
Open

Turn off the Default Bucket in COS class #32

bassel-zeidan opened this issue Oct 9, 2017 · 1 comment

Comments

@bassel-zeidan
Copy link
Collaborator

With Default Bucket:

  • Pros: easier since most of the time user wants to fetch data from the same bucket.
  • Cons: inconsistent with other classes

Without Default Bucket:

  • Pros: consistent with other classes.
  • Cons: 1) break libs that already use ibmos2spark when the change occurs directly on the url function (backward compatibility issue). 2) we lose the default Bucket value.
@bassel-zeidan
Copy link
Collaborator Author

If we decide to go with a change, we need to think of a way of how to maintain the backward compatibility of the lib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant