Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream ChangeLogo / bbappend file failed to load sensor yaml #3632

Open
gtmills opened this issue Jun 21, 2023 · 7 comments
Open

Upstream ChangeLogo / bbappend file failed to load sensor yaml #3632

gtmills opened this issue Jun 21, 2023 · 7 comments
Assignees
Labels
ReadyForDev Stories ready for development work

Comments

@gtmills
Copy link

gtmills commented Jun 21, 2023

Would be great if commits:
ibm-openbmc/openbmc#285
and
ibm-openbmc/openbmc#284
could go upstream.
Would have to upstream the entire changeLogo stuff.

Thanks for all the help!

@gtmills gtmills added the ReadyForDev Stories ready for development work label Jun 21, 2023
@lxwinspur
Copy link

Sure @gtmills
Will do

@lxwinspur
Copy link

For ibm-openbmc/openbmc#284
IBM did not upstream this feature.

@gtmills
Copy link
Author

gtmills commented Aug 23, 2023

For ibm-openbmc/openbmc#284
IBM did not upstream this feature.

@lxwinspur can IPS help us here by upstreaming ?

@lxwinspur
Copy link

@gtmills
Copy link
Author

gtmills commented Sep 7, 2023

Review by: https://gerrit.openbmc.org/c/openbmc/openbmc/+/66406

Thanks! The community had a strong reaction to this.. I wonder if IPS could create an env.ips similar to https://github.com/ibm-openbmc/webui-vue/blob/1050/.env.ibm and set the logo there and do their other webui-vue changes ? And then in a bbappend that could be set to --mode ips

@gtmills
Copy link
Author

gtmills commented Dec 12, 2023

Still a valid issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReadyForDev Stories ready for development work
Projects
None yet
Development

No branches or pull requests

2 participants