Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redfish : Look for OperationalStatus for the Health and HealthRollUp in health.hpp #3193

Open
ChicagoDuan opened this issue May 18, 2021 · 4 comments
Assignees
Labels
Migrate-No Do not migrate to Jira prio_high_1 ReadyForDev Stories ready for development work
Milestone

Comments

@ChicagoDuan
Copy link
Member

health.hpp should be modified to look for OperationalStatus for the Health and HealthRollUp.
Ideally, all resources would then use health.hpp.
It might make sense to rename health.hpp to status.hpp and have it do the health, healthrollup, and state.
#2795 (comment)

Step 1 :
We should push a paragraph to : https://github.com/openbmc/docs/blob/919a7b6816a5f16aa72d298e81e0756d95d5031e/designs/redfish-health-rolllup.md#proposed-design
E.g.

# Individual Resource Health 
All resources should look at OperationalStatus  to determine the Health 

Step 2:
Modify the health.hpp to look for OperationalStatus for the Health and HealthRollUp.

@ChicagoDuan ChicagoDuan added the ReadyForDev Stories ready for development work label May 18, 2021
@rfrandse rfrandse added this to the A.1.999 milestone May 20, 2021
@vishwabmc
Copy link

@ChicagoDuan Isn't health.cpp already looking at OperationalStatus to populate Health ?.

or , may be processor / DIMMs / Fans, individually have hooks on OperationalStatus and then use Health also ?. Because, I can today set health of Fan using OperationalStatus

https://github.com/openbmc/bmcweb/blob/master/redfish-core/lib/processor.hpp#L76

https://github.com/openbmc/bmcweb/blob/master/redfish-core/lib/sensors.hpp#L801

@gtmills @lkammath

@ChicagoDuan
Copy link
Member Author

@ChicagoDuan Isn't health.cpp already looking at OperationalStatus to populate Health ?.

or , may be processor / DIMMs / Fans, individually have hooks on OperationalStatus and then use Health also ?. Because, I can today set health of Fan using OperationalStatus

https://github.com/openbmc/bmcweb/blob/master/redfish-core/lib/processor.hpp#L76

https://github.com/openbmc/bmcweb/blob/master/redfish-core/lib/sensors.hpp#L801

@gtmills @lkammath

Now health.hpp doesn't look for OperationalStatus.
You can today set health of Fan using OperationalStatus, because it not uses health.hpp

@ChicagoDuan
Copy link
Member Author

@mzipse mzipse modified the milestones: A.1.999, A.1.213.7 Jun 22, 2021
@mzipse mzipse added the Migrate-No Do not migrate to Jira label Oct 26, 2022
@gtmills
Copy link

gtmills commented Dec 12, 2023

This isn't complete, can we move all bmcweb resources to use OperationalStatus?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Migrate-No Do not migrate to Jira prio_high_1 ReadyForDev Stories ready for development work
Projects
None yet
Development

No branches or pull requests

7 participants