Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for OEM Systems #2895

Open
geissonator opened this issue Feb 4, 2021 · 8 comments
Open

Support for OEM Systems #2895

geissonator opened this issue Feb 4, 2021 · 8 comments
Assignees
Labels
Migrate-No Do not migrate to Jira prio_high_2 ReadyForDev Stories ready for development work
Milestone

Comments

@geissonator
Copy link

geissonator commented Feb 4, 2021

When partners wish to build a system based on IBM hardware, we need to ensure we provide a mechanism for them to do this. For example, they'll want a way to put their own logo in the web interface.

Some other things to consider:

  • A custom hostname
  • A different IPMI IANA number
  • Other minor web interface customizations

The direction for P10 is to have a field in the VPD which will indicate the type of system. We'll use a service like that in ibm-openbmc/openbmc@69ae2e0 to ensure the correct logo is loaded.

@geissonator geissonator added this to the A.1.213 milestone Feb 4, 2021
@geissonator
Copy link
Author

FYI @gtmills

@rfrandse rfrandse modified the milestones: A.1.213, A.1.999 Feb 6, 2021
@mzipse mzipse modified the milestones: A.1.999, A.1.888 May 14, 2021
@rfrandse rfrandse modified the milestones: A.1.888, A.1.999 Jun 18, 2021
@mzipse mzipse modified the milestones: A.1.999, A.1.888 Jun 22, 2021
@geissonator
Copy link
Author

This story will track the following:

Need details from @santoshpuranik (?) on what VPD keyword will be used for this and what the different possible values are.

A custom hostname should not be needed as the default is just "p10bmc" now which should be fine for all system types.

I'm not sure if a different IPMI IANA number is needed or not.

@gtmills
Copy link

gtmills commented Feb 26, 2022

We should follow the design in ibm-openbmc/openbmc@69ae2e0
No changes to the GUI or bmcweb needed here

@mzipse mzipse added ReadyForDev Stories ready for development work prio_high_2 labels Apr 14, 2022
@geissonator
Copy link
Author

geissonator commented Jul 21, 2022

ok, so as Gunnar mentioned, this is going to look at lot like ibm-openbmc/openbmc@69ae2e0

The work:

  • @kennyneedsmilky is working on a change to the GUI code to make the logo file names generic (they were switched to something more IBM specific in vue). Once he has that, we'll update this issue with new file names.
  • The files to override are in /usr/share/www/img/ on eBMC p10bmc images
  • Instead of using the Model, we're going to use the Brand. To get the Brand in your script, use the following:
busctl get-property xyz.openbmc_project.Inventory.Manager /xyz/openbmc_project/inventory/system xyz.openbmc_project.Inventory.Decorator.Asset SubModel

S0 || D0 = IBM
J0 = IPS (need IPS to confirm this)
ANYTHING ELSE = OEM

All of this should be built into the p10bmc image so it will support all 3 Brands in a single image.

@lxwinspur lxwinspur self-assigned this Jul 25, 2022
@geissonator
Copy link
Author

The needed GUI change is merged up at ibm-openbmc/webui-vue@924cd30

@lxwinspur
Copy link

@geissonator @mzipse
Review by: ibm-openbmc/openbmc#231

lxwinspur added a commit to lxwinspur/openbmc that referenced this issue Aug 2, 2022
Add change-logo service to detect whether there is a keyword in the
VPD, if it exists, the original logo will be replaced with a inspur
logo.

issues: ibm-openbmc/dev#2895

Signed-off-by: George Liu <[email protected]>
lxwinspur added a commit to lxwinspur/openbmc that referenced this issue Aug 3, 2022
Add change-logo service to detect whether there is a keyword in the
VPD, if it exists, the original logo will be replaced with a inspur
logo.

issues: ibm-openbmc/dev#2895

Signed-off-by: George Liu <[email protected]>
lxwinspur added a commit to lxwinspur/openbmc that referenced this issue Aug 3, 2022
Add change-logo service to detect whether there is a keyword in the
VPD, if it exists, the original logo will be replaced with a inspur
logo.

issues: ibm-openbmc/dev#2895

Signed-off-by: George Liu <[email protected]>
rfrandse pushed a commit to ibm-openbmc/openbmc that referenced this issue Aug 3, 2022
* meta-ibm: Add the change-logo service for IPS

Add change-logo service to detect whether there is a keyword in the
VPD, if it exists, the original logo will be replaced with a inspur
logo.

issues: ibm-openbmc/dev#2895

Signed-off-by: George Liu <[email protected]>

* meta-ibm: change-logo fixes

Some fixes found in testing this PR

Tested:
- Verified default path when brand is IBM
- Verified IPS logo loaded in GUI when brand is J0
- Verified transparent logo loaded for any other brand

Signed-off-by: Andrew Geissler <[email protected]>

Co-authored-by: George Liu <[email protected]>
@geissonator
Copy link
Author

Put in under ibm-openbmc/openbmc#233

@ghost
Copy link

ghost commented Aug 3, 2022

ok, so as Gunnar mentioned, this is going to look at lot like ibm-openbmc/openbmc@69ae2e0

The work:

  • @kennyneedsmilky is working on a change to the GUI code to make the logo file names generic (they were switched to something more IBM specific in vue). Once he has that, we'll update this issue with new file names.
  • The files to override are in /usr/share/www/img/ on eBMC p10bmc images
  • Instead of using the Model, we're going to use the Brand. To get the Brand in your script, use the following:
busctl get-property xyz.openbmc_project.Inventory.Manager /xyz/openbmc_project/inventory/system xyz.openbmc_project.Inventory.Decorator.Asset SubModel

S0 || D0 = IBM J0 = IPS (need IPS to confirm this) ANYTHING ELSE = OEM

All of this should be built into the p10bmc image so it will support all 3 Brands in a single image.

Handle now changed to @kennyfully88 . Sorry for the confusion

rfrandse pushed a commit to ibm-openbmc/openbmc that referenced this issue Oct 25, 2022
* meta-ibm: Add the change-logo service for IPS

Add change-logo service to detect whether there is a keyword in the
VPD, if it exists, the original logo will be replaced with a inspur
logo.

issues: ibm-openbmc/dev#2895

Signed-off-by: George Liu <[email protected]>

* meta-ibm: change-logo fixes

Some fixes found in testing this PR

Tested:
- Verified default path when brand is IBM
- Verified IPS logo loaded in GUI when brand is J0
- Verified transparent logo loaded for any other brand

Signed-off-by: Andrew Geissler <[email protected]>

Co-authored-by: George Liu <[email protected]>
@mzipse mzipse added the Migrate-No Do not migrate to Jira label Oct 26, 2022
rfrandse pushed a commit to ibm-openbmc/openbmc that referenced this issue Oct 26, 2022
* meta-ibm: Add the change-logo service for IPS

Add change-logo service to detect whether there is a keyword in the
VPD, if it exists, the original logo will be replaced with a inspur
logo.

issues: ibm-openbmc/dev#2895

Signed-off-by: George Liu <[email protected]>

* meta-ibm: change-logo fixes

Some fixes found in testing this PR

Tested:
- Verified default path when brand is IBM
- Verified IPS logo loaded in GUI when brand is J0
- Verified transparent logo loaded for any other brand

Signed-off-by: Andrew Geissler <[email protected]>

Co-authored-by: George Liu <[email protected]>
anoo1 pushed a commit to anoo1/openbmc-1 that referenced this issue Oct 28, 2022
* meta-ibm: Add the change-logo service for IPS

Add change-logo service to detect whether there is a keyword in the
VPD, if it exists, the original logo will be replaced with a inspur
logo.

issues: ibm-openbmc/dev#2895

Signed-off-by: George Liu <[email protected]>

* meta-ibm: change-logo fixes

Some fixes found in testing this PR

Tested:
- Verified default path when brand is IBM
- Verified IPS logo loaded in GUI when brand is J0
- Verified transparent logo loaded for any other brand

Signed-off-by: Andrew Geissler <[email protected]>

Co-authored-by: George Liu <[email protected]>
spinler pushed a commit to spinler/openbmc that referenced this issue Nov 15, 2022
…penbmc#2776)

* meta-ibm: Add the change-logo service for IPS

Add change-logo service to detect whether there is a keyword in the
VPD, if it exists, the original logo will be replaced with a inspur
logo.

issues: ibm-openbmc/dev#2895

Signed-off-by: George Liu <[email protected]>

* meta-ibm: change-logo fixes

Some fixes found in testing this PR

Tested:
- Verified default path when brand is IBM
- Verified IPS logo loaded in GUI when brand is J0
- Verified transparent logo loaded for any other brand

Signed-off-by: Andrew Geissler <[email protected]>

Co-authored-by: George Liu <[email protected]>

Co-authored-by: Andrew Geissler <[email protected]>
Co-authored-by: George Liu <[email protected]>
rfrandse pushed a commit to ibm-openbmc/openbmc that referenced this issue Jan 3, 2023
* meta-ibm: Add the change-logo service for IPS

Add change-logo service to detect whether there is a keyword in the
VPD, if it exists, the original logo will be replaced with a inspur
logo.

issues: ibm-openbmc/dev#2895

Signed-off-by: George Liu <[email protected]>

* meta-ibm: change-logo fixes

Some fixes found in testing this PR

Tested:
- Verified default path when brand is IBM
- Verified IPS logo loaded in GUI when brand is J0
- Verified transparent logo loaded for any other brand

Signed-off-by: Andrew Geissler <[email protected]>

Co-authored-by: George Liu <[email protected]>
stefanberger pushed a commit to stefanberger/openbmc that referenced this issue Aug 1, 2023
* meta-ibm: Add the change-logo service for IPS

Add change-logo service to detect whether there is a keyword in the
VPD, if it exists, the original logo will be replaced with a inspur
logo.

issues: ibm-openbmc/dev#2895

Signed-off-by: George Liu <[email protected]>

* meta-ibm: change-logo fixes

Some fixes found in testing this PR

Tested:
- Verified default path when brand is IBM
- Verified IPS logo loaded in GUI when brand is J0
- Verified transparent logo loaded for any other brand

Signed-off-by: Andrew Geissler <[email protected]>

Co-authored-by: George Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Migrate-No Do not migrate to Jira prio_high_2 ReadyForDev Stories ready for development work
Projects
None yet
Development

No branches or pull requests

5 participants