-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for OEM Systems #2895
Comments
FYI @gtmills |
This story will track the following:
Need details from @santoshpuranik (?) on what VPD keyword will be used for this and what the different possible values are. A custom hostname should not be needed as the default is just "p10bmc" now which should be fine for all system types. I'm not sure if a different IPMI IANA number is needed or not. |
We should follow the design in ibm-openbmc/openbmc@69ae2e0 |
ok, so as Gunnar mentioned, this is going to look at lot like ibm-openbmc/openbmc@69ae2e0 The work:
S0 || D0 = IBM All of this should be built into the p10bmc image so it will support all 3 Brands in a single image. |
The needed GUI change is merged up at ibm-openbmc/webui-vue@924cd30 |
@geissonator @mzipse |
Add change-logo service to detect whether there is a keyword in the VPD, if it exists, the original logo will be replaced with a inspur logo. issues: ibm-openbmc/dev#2895 Signed-off-by: George Liu <[email protected]>
Add change-logo service to detect whether there is a keyword in the VPD, if it exists, the original logo will be replaced with a inspur logo. issues: ibm-openbmc/dev#2895 Signed-off-by: George Liu <[email protected]>
Add change-logo service to detect whether there is a keyword in the VPD, if it exists, the original logo will be replaced with a inspur logo. issues: ibm-openbmc/dev#2895 Signed-off-by: George Liu <[email protected]>
* meta-ibm: Add the change-logo service for IPS Add change-logo service to detect whether there is a keyword in the VPD, if it exists, the original logo will be replaced with a inspur logo. issues: ibm-openbmc/dev#2895 Signed-off-by: George Liu <[email protected]> * meta-ibm: change-logo fixes Some fixes found in testing this PR Tested: - Verified default path when brand is IBM - Verified IPS logo loaded in GUI when brand is J0 - Verified transparent logo loaded for any other brand Signed-off-by: Andrew Geissler <[email protected]> Co-authored-by: George Liu <[email protected]>
Put in under ibm-openbmc/openbmc#233 |
Handle now changed to @kennyfully88 . Sorry for the confusion |
* meta-ibm: Add the change-logo service for IPS Add change-logo service to detect whether there is a keyword in the VPD, if it exists, the original logo will be replaced with a inspur logo. issues: ibm-openbmc/dev#2895 Signed-off-by: George Liu <[email protected]> * meta-ibm: change-logo fixes Some fixes found in testing this PR Tested: - Verified default path when brand is IBM - Verified IPS logo loaded in GUI when brand is J0 - Verified transparent logo loaded for any other brand Signed-off-by: Andrew Geissler <[email protected]> Co-authored-by: George Liu <[email protected]>
* meta-ibm: Add the change-logo service for IPS Add change-logo service to detect whether there is a keyword in the VPD, if it exists, the original logo will be replaced with a inspur logo. issues: ibm-openbmc/dev#2895 Signed-off-by: George Liu <[email protected]> * meta-ibm: change-logo fixes Some fixes found in testing this PR Tested: - Verified default path when brand is IBM - Verified IPS logo loaded in GUI when brand is J0 - Verified transparent logo loaded for any other brand Signed-off-by: Andrew Geissler <[email protected]> Co-authored-by: George Liu <[email protected]>
* meta-ibm: Add the change-logo service for IPS Add change-logo service to detect whether there is a keyword in the VPD, if it exists, the original logo will be replaced with a inspur logo. issues: ibm-openbmc/dev#2895 Signed-off-by: George Liu <[email protected]> * meta-ibm: change-logo fixes Some fixes found in testing this PR Tested: - Verified default path when brand is IBM - Verified IPS logo loaded in GUI when brand is J0 - Verified transparent logo loaded for any other brand Signed-off-by: Andrew Geissler <[email protected]> Co-authored-by: George Liu <[email protected]>
…penbmc#2776) * meta-ibm: Add the change-logo service for IPS Add change-logo service to detect whether there is a keyword in the VPD, if it exists, the original logo will be replaced with a inspur logo. issues: ibm-openbmc/dev#2895 Signed-off-by: George Liu <[email protected]> * meta-ibm: change-logo fixes Some fixes found in testing this PR Tested: - Verified default path when brand is IBM - Verified IPS logo loaded in GUI when brand is J0 - Verified transparent logo loaded for any other brand Signed-off-by: Andrew Geissler <[email protected]> Co-authored-by: George Liu <[email protected]> Co-authored-by: Andrew Geissler <[email protected]> Co-authored-by: George Liu <[email protected]>
* meta-ibm: Add the change-logo service for IPS Add change-logo service to detect whether there is a keyword in the VPD, if it exists, the original logo will be replaced with a inspur logo. issues: ibm-openbmc/dev#2895 Signed-off-by: George Liu <[email protected]> * meta-ibm: change-logo fixes Some fixes found in testing this PR Tested: - Verified default path when brand is IBM - Verified IPS logo loaded in GUI when brand is J0 - Verified transparent logo loaded for any other brand Signed-off-by: Andrew Geissler <[email protected]> Co-authored-by: George Liu <[email protected]>
* meta-ibm: Add the change-logo service for IPS Add change-logo service to detect whether there is a keyword in the VPD, if it exists, the original logo will be replaced with a inspur logo. issues: ibm-openbmc/dev#2895 Signed-off-by: George Liu <[email protected]> * meta-ibm: change-logo fixes Some fixes found in testing this PR Tested: - Verified default path when brand is IBM - Verified IPS logo loaded in GUI when brand is J0 - Verified transparent logo loaded for any other brand Signed-off-by: Andrew Geissler <[email protected]> Co-authored-by: George Liu <[email protected]>
When partners wish to build a system based on IBM hardware, we need to ensure we provide a mechanism for them to do this. For example, they'll want a way to put their own logo in the web interface.
Some other things to consider:
The direction for P10 is to have a field in the VPD which will indicate the type of system. We'll use a service like that in ibm-openbmc/openbmc@69ae2e0 to ensure the correct logo is loaded.
The text was updated successfully, but these errors were encountered: