You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After upgrading to Intern 3 and running the ViewStack unit tests, I get failures in Chrome 48/mac and also other browsers. The first failure is in the Show (reverse, flip) test.
The problem happens when you show a node immediately after hiding it.
ViewStack is supposed to add classes to a node as the transition starts, and then remove the classes when the transition ends 300ms later. The failure is because ViewStack tries to remove the classes before it adds them. It occurs because of two issues:
When showing a node immediately after hiding it, the transitionEnd event occurs immediately, rather than in 300ms like it's supposed to. Browser bug? I'm not sure. It occurs on multiple browsers.
I don't know why, but ViewStack has a delay before it adds the classes to nodes that are in transition:
Detailed changes:
* Leverage defaultTimeout config parameter rather than setting a timeout for every test.
* For firefox, needed to upgrade from selenium-server 2.44.0 to 2.47.1.
* Installed requirejs via npm to make Intern 3 work,
because when you install requirejs via bower, you don't get r.js,
and r.js is what's needed by Node.
* Also required leadfoot directly, since setting loaderOptions.packages
to map leadfoot --> intern/node_modules/leadfoot doesn't seem to work,
apparently an Intern bug.
* Remove customRunner since Intern now logs test start and skip by default
Note that there are test failures both before and after this change, but for Chrome/mac
the failure count actually goes down, from 15~19 to 8, including the 5 failures
from #594.
wkeese
changed the title
ViewStack: classes not removed after transition ends
ViewStack: problems when showing a node immediately after hiding it
Mar 6, 2016
wkeese
added a commit
to wkeese/deliteful
that referenced
this issue
Mar 7, 2016
After upgrading to Intern 3 and running the ViewStack unit tests, I get failures in Chrome 48/mac and also other browsers. The first failure is in the
Show (reverse, flip)
test.The problem happens when you show a node immediately after hiding it.
ViewStack is supposed to add classes to a node as the transition starts, and then remove the classes when the transition ends 300ms later. The failure is because ViewStack tries to remove the classes before it adds them. It occurs because of two issues:
transitionEnd
event occurs immediately, rather than in 300ms like it's supposed to. Browser bug? I'm not sure. It occurs on multiple browsers.On Chrome
this._timing
is 20ms.The text was updated successfully, but these errors were encountered: