Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a search feature #275

Closed
iamlogand opened this issue Oct 1, 2023 · 1 comment
Closed

Add a search feature #275

iamlogand opened this issue Oct 1, 2023 · 1 comment
Labels
feature Feature or enhancement proposal Idea, suggestion or some other deliverable

Comments

@iamlogand
Copy link
Owner

iamlogand commented Oct 1, 2023

Add a search bar or icon somewhere. Clicking it should open a search dialog box containing a search bar and the search results (taking inspiration from the search features on sites like https://tailwindcss.com and https://mui.com/).

The searchable items can be Factions, Senators, and Terms.

The search dialog should contain a search bar at the top, then, beneath that, a list of all Factions, Senators, and Terms. These can all be represented by text for now. Typing something into the search bar should narrow the results, with the list being updated immediately upon any change to the search text, character by character. The top item should be initially selected, but pressing the up or down arrow key can allow moving the selection to other items. Pressing enter or clicking an item should close the search dialog and open the detail section for the selected item.

@iamlogand iamlogand added the feature Feature or enhancement label Oct 1, 2023
@iamlogand iamlogand added proposal Idea, suggestion or some other deliverable and removed feature Feature or enhancement labels Nov 12, 2023
@iamlogand iamlogand added the feature Feature or enhancement label Feb 5, 2024
@iamlogand
Copy link
Owner Author

Closing because this was delivered by #449 and #451.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature or enhancement proposal Idea, suggestion or some other deliverable
Projects
None yet
Development

No branches or pull requests

1 participant