Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Peer dependencies for React 19 #614

Open
ahmadi3d opened this issue Nov 14, 2024 · 11 comments
Open

Update Peer dependencies for React 19 #614

ahmadi3d opened this issue Nov 14, 2024 · 11 comments

Comments

@ahmadi3d
Copy link

Hello
Can you please update the Peer Dependencies for React 19 ? I believe none of the changes are breaking changes, Thank you!

@viktor21minds
Copy link

any progress on this?

@RunRanger
Copy link

Since there're PRs open over 2 month ago i believe this repository is dead...

@BarishSarac
Copy link

#615

@ahmadi3d
Copy link
Author

@BarishSarac The code you sent does it support stacking and the enter exit animation too ?

@RunRanger
Copy link

RunRanger commented Dec 10, 2024

I would recommend to switch to
react-toastify
or
sonner

@ahmadi3d
Copy link
Author

@RunRanger Yes, I found React-Toastify to be the best alternative as well. However, considering the refactoring involved, I’ll likely write my own wrapper and create a structure similar to Notistack. Inside the wrapper, I’ll use React-Toastify. This way, if I ever want to change the library in the future, I won’t have to refactor everything again.

@BarishSarac
Copy link

Stacking yes, you can set the maxstack in it as you wish. Animation no, I'm sure if you plug it into AI and ask it to add in animation it could. I am tired of using these 3rd parties and coming to a date where they dont update to match latest stuff or fix a bug or dont have some feature thats so must have. I'll try hardest not to use 3rd party now.

@Zitrooone
Copy link

+1 for this, even though it seems unlikely that something will happen.

@Ben-CA
Copy link

Ben-CA commented Dec 27, 2024

+1 for supporting React 19 without --legacy-peer-deps

@nagy135
Copy link

nagy135 commented Dec 27, 2024

the crazy part here is that big ui library like MUI depends on this dead library to not render toasts on top of each other

@Ben-CA
Copy link

Ben-CA commented Dec 27, 2024

Yeah, with 3M downloads a month, and 836 dependencies on NPM, it would be nice if we could just get React 19 support added...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants