Temp Radium example #167
Closed
Temp Radium example #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lerplate into kk # By iam4x # Via iam4x * 'master' of https://github.com/iam4x/isomorphic-flux-boilerplate: chore: update deps
* master: refactor: load stores/actions programaticaly fix(guides): missing i18n data fix(docker): update npm && node version chore: bump boilerplate version fix: throw error as an object with `redirect` && `error` key refactor refactor test: update tests with context doc: update doc, now use `context` refactor: use `connect-alt` decorator fix: tests chore: drop `cssnext`, update `postcss` and use `precss` refactor style: disable `react/display-name` refactor: webpack config style: disable `react/display-name` Conflicts: app/components/app.jsx app/utils/flux.js server/router.jsx
* master: refactor: move actions, stores into a flux dir && move AltResolver.render into `universerval-render`
* master: fix: use axios fork test: add tests with faking xhr doc: add note about ApiClient feat(api): use API in the App feat(api): add an API router on koa server feat(apiClient): add an ApiClient for easier requests fix(header): update loader chore: use circleci style: use `precss` features chore: bump travis nodejs version to `4.2.1` Conflicts: app/components/header.jsx
* master: fix(altResolver) test: fix eslint refactor: drop lodash `mapValues` chore: update deps ([email protected] 🎉) fix: code style (fixes #142) Conflicts: package.json
# Conflicts: # package.json # server/views/layouts/index.hbs
|
Nice! It's nice to have an example with radium, do you have so code clean to do? I would like to publish this as another branch to give people the choice 👍 |
* master: (21 commits) style: lint tests as well feat(koa-2.0.0): update code feat(koa-2.0.0): update middlewares chore(koa-2.0.0): update deps fix(universal-render): iso returns DOMNode on 2nd parameter now chore: update `axios` to `0.8` which supports gzip chore: bump node version style: update style to `airbnb` doc: update `README.md` for `0.5.0` chore: update `iso` dep feat(alt-0.18): call `alt-resolver` with new alt fn return feat(alt.0-18): dont override `addActions` to pass `alt` instance into actions feat(alt-resolver): dont wrap action into promises refactor: remove not used param in `switchLocale` fix(users): use `this._flux` instead of `this.alt` fix(locale): use `dispatch()` in alt 0.18 feat(alt-0.18): pass alt instance into actions chore: use `alt-utils` chore: update deps fix history dependency and warning ... Conflicts: app/components/header.jsx app/routes.jsx package.json server/server-html.jsx test/spec/components/app.test.jsx test/spec/components/header.test.jsx test/spec/components/lang-picker.test.jsx test/spec/components/profile.test.jsx test/spec/stores/users.test.js
|
@iam4x yes i can prepare a pull request later |
|
Yea I would like to see the latest master pulled into this and working clean so I could try to switch to Radium. CSS files are just a mess and becoming hard to maintain when I have almost 50 components. |
|
@jaredkotoff see #225 |
|
Moved to #225 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Miss pull request, sorry.