Unsecure ssl support #92
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InfluxDbHttpSender - using http://www.nakov.com/blog/2009/07/16/disable-certificate-validation-in-java-ssl-connections/ as reference, use additional parameters to disable cert/hostname verification, if unsecure ssl is required. InfluxDbReporterFactory - support the new parameters when read through json properties README.md - updated to reflect additional parameters and their default values
InfluxDbHttpSenderTest.shouldThrowConnectException throws SocketTimeoutException for slow / non-responsive setups, fixed by making the timeout 0
|
Well, some response would be nice... |
|
Hi @royshahaf yes it is somewhat in a state of dormancy and contributions aren't actively inspected as you can see by the very late reply here! |
I see :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
While using this repo on-prem and trying to get https to work (I write both the server and the client, and was trying to self-sign certificates while our CA was unavailable), I encountered the following issue:
When influxdb is using an unsecure certificate (for example, if the CA that signed it is not trusted), InfluxDbHttpSender cannot send metrics to influxdb (client will refuse to connect to an untrusted influxdb).
While I agree this default behavior sounds like a good choice, I wanted to allow unsecure https for the sake of https integration when a CA is unavailable.
I made the changes in my own fork (on-prem) but thought it may be nice to port them back to the community.