fix(wms) : assign axis order param from source #2465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airnez
force-pushed
the
fix/use-wms-axisorder-param
branch
from
47dfdd7
to
4f2d77b
Compare
Desplandis
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Thanks for the fix! It was indeed documented and missing...
I have however a few comments with our current implementation in iTowns. Reading geoserver's notes on the WMS specification, it seems that
-
The WMS 1.1 always uses east/north axis ordering.
Shall we for WMS
$<1.3.0$ queries default towsenfor all CRS (instead of justEPSG:4326)? -
The WMS 1.3.0 specification mandates using the axis ordering as defined in the EPSG database.
It would be nice again to not just handle the
EPSG:4326projection, and maybe use the projection definition fromproj4to determine the axis ordering+axis. This could be a nice addition to theCRSmodule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WMSSource was'nt taking the axisOrder parameter into account when provided.
Motivation and Context
Consistency: This parameter was advertised in documentation while not being used afterwards.