Fix pylint warnings (#287)

custom_components/tahoma/binary_sensor.py

@@ -106,8 +106,7 @@ def icon(self) -> Optional[str]:
         if self.device_class == DEVICE_CLASS_WATER:
             if self.is_on:
                 return ICON_WATER
-            else:
-                return ICON_WATER_OFF
+            return ICON_WATER_OFF
 
         icons = {DEVICE_CLASS_GAS: ICON_WAVES, DEVICE_CLASS_RAIN: ICON_WEATHER_RAINY}
 

custom_components/tahoma/config_flow.py

@@ -1,5 +1,4 @@
 """Config flow for TaHoma integration."""
-from asyncio import TimeoutError
 import logging
 
 from aiohttp import ClientError
@@ -12,12 +11,8 @@
 from homeassistant.core import callback
 from homeassistant.helpers import config_validation as cv
 
-from .const import (
-    CONF_UPDATE_INTERVAL,
-    DEFAULT_UPDATE_INTERVAL,
-    DOMAIN,
-    MIN_UPDATE_INTERVAL,
-)
+from .const import CONF_UPDATE_INTERVAL, DEFAULT_UPDATE_INTERVAL, MIN_UPDATE_INTERVAL
+from .const import DOMAIN  # pylint: disable=unused-import
 
 _LOGGER = logging.getLogger(__name__)
 

custom_components/tahoma/coordinator.py

@@ -57,22 +57,27 @@ async def _async_update_data(self) -> Dict[str, Device]:
         """Fetch TaHoma data via event listener."""
         try:
             events = await self.client.fetch_events()
-        except BadCredentialsException:
-            raise UpdateFailed("invalid_auth")
-        except TooManyRequestsException:
-            raise UpdateFailed("too_many_requests")
+        except BadCredentialsException as exception:
+            raise UpdateFailed("invalid_auth") from exception
+        except TooManyRequestsException as exception:
+            raise UpdateFailed("too_many_requests") from exception
         except (ServerDisconnectedError, NotAuthenticatedException):
             self.executions = {}
             await self.client.login()
             self.devices = await self._get_devices()
             return self.devices
         except Exception as exception:
             _LOGGER.debug(exception)
-            raise UpdateFailed(exception)
+            raise UpdateFailed(exception) from exception
 
         for event in events:
             _LOGGER.debug(
-                f"{event.name}/{event.exec_id} (device:{event.deviceurl},state:{event.old_state}->{event.new_state})"
+                "%s/%s (device: %s, state: %s -> %s)",
+                event.name,
+                event.exec_id,
+                event.deviceurl,
+                event.old_state,
+                event.new_state,
             )
 
             if event.name == EventName.DEVICE_AVAILABLE:

custom_components/tahoma/cover.py

@@ -243,8 +243,7 @@ def icon(self):
         ):
             if self.select_state(IO_PRIORITY_LOCK_ORIGINATOR_STATE) == "wind":
                 return ICON_WEATHER_WINDY
-            else:
-                return ICON_LOCK_ALERT
+            return ICON_LOCK_ALERT
 
         return None
 

custom_components/tahoma/sensor.py

@@ -28,7 +28,7 @@
 
 try:  # TODO: Remove for core PR. This ensures compatibility with <0.115
     from homeassistant.const import PERCENTAGE
-except Exception:
+except Exception:  # pylint: disable=broad-except
     from homeassistant.const import UNIT_PERCENTAGE as PERCENTAGE
 
 

custom_components/tahoma/services.yaml

@@ -13,7 +13,7 @@ set_light_my_position:
       example: "light.living_room"
 
 set_cover_position_low_speed:
-  description:  Move to specific position all or specified cover with a low speed.
+  description: Move to specific position all or specified cover with a low speed.
   fields:
     entity_id:
       description: Name(s) of cover(s) to set cover position with a low speed.
@@ -33,4 +33,4 @@ execute_command:
       example: "setIntensity"
     args:
       description: List of arguments to pass to the command if necessary
-      example: 100
+      example: 100

custom_components/tahoma/switch.py

@@ -58,8 +58,7 @@ def icon(self) -> Optional[str]:
         if self.device_class == DEVICE_CLASS_SIREN:
             if self.is_on:
                 return ICON_BELL_RING
-            else:
-                return ICON_BELL_OFF
+            return ICON_BELL_OFF
 
         return None
 

custom_components/tahoma/tahoma_device.py

@@ -166,7 +166,7 @@ async def async_execute_command(self, command_name: str, *args: Any):
                 Command(command_name, list(args)),
                 "Home Assistant",
             )
-        except Exception as exception:
+        except Exception as exception:  # pylint: disable=broad-except
             _LOGGER.error(exception)
             return
 

tests/test_config_flow.py

@@ -6,7 +6,6 @@
 
 from pyhoma.exceptions import BadCredentialsException, TooManyRequestsException
 import pytest
-from asyncio import TimeoutError
 from aiohttp import ClientError
 
 from homeassistant import config_entries