TypeError on save upload #9
Comments
|
Been taking a crack at this locally and was able to find a solution that I think works for preventing breakage with both Main and Subject 2923 campaigns, though parsing 2923 campaign events is of course not an option without writing all that in. Maybe I can do that too, but it's outside the scope of this issue. It now shows me a Corsus Adventure mode, but it doesn't appear to be my active adventure mode. The Adventure I already have active (and have entirely completed, as far as I can tell) is here (line 310 of the file): But the events that actually show up when it parses my adventure mode is from a second section, here (line 7 of the file): I'm hoping this issue makes more sense to someone more knowledgeable about these save files. What is Edit: Been debugging pretty thoroughly and I think I see the problem, but I don't know the solution. My Adventure Mode quests do get picked up in tempList, but at I'm sure array index 1 is a magic number of some significance, but I'm not sure what that is. It makes this a bit troublesome. I'm attaching my save file here in case you or anyone else cares to investigate. It should be showing Dream Eater, Queen's Sanctum, the Guardian, some other stuff. Instead, it shows Graveyard Elf, BrainBug, and several other things that are (unfortunately) not in this particular adventure. |
|
I was able to get everything working locally by checking for campaign type (Main or Clementine--that is, 2923). On a Main campaign the code runs as normal, on a Clementine it uses some different splits to find the campaign data (to avoid further TypeErrors) and pulls I still need to make sure this is a viable solution. I've got a friend's save with a Main campaign to test that I'm not breaking any existing functionality, but I'll need to wheedle some other friends for 2923 saves for further testing; I don't want to submit a PR only to find that my magic number is bad and it breaks on other people's saves. I also don't feel super comfy adding a magic number into the codebase at all, especially when I don't know why it works out the way it does. |
|
The |
- resolve issue hzla#9 - add logic to check the campaign type - change the place in the save file where adventure mode data is taken - accomodates both campaign types - no support for subject 2923 campaign events or reisum adventures yet, but this is the first step.
- resolve issue hzla#9 - add logic to check the campaign type - change the place in the save file where adventure mode data is taken - accomodates both campaign types - no support for subject 2923 campaign events or reisum adventures yet, but this is the first step.
Having trouble with the js breaking at Line 286.
Uncaught TypeError: Cannot read property 'replace' of undefinedWorth noting that I have a Subject 2923 campaign, I am running a Corsus adventure mode, and I attempted to upload the save file directly after I loaded into the Swamp.
Using notepad++ to read the save file directly gives a real mess, but the only
/Quest/Campaign_Main/instance in it is/Game/Campaign_Main/Items/QuestItems/Quest_FoundersKey.Quest_FoundersKey_CThe text was updated successfully, but these errors were encountered: