Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dummy Camera Params - Focal Length #38

Open
cancan101 opened this issue Mar 29, 2023 · 0 comments
Open

Dummy Camera Params - Focal Length #38

cancan101 opened this issue Mar 29, 2023 · 0 comments

Comments

@cancan101
Copy link

It looks like in generate_dummy_camera_params, when generating the camera matrix, the focal length is assumed to be the width:

pytorch_mpiigaze_demo/ptgaze/utils.py

Line 125 in 47cdf68

'data': [w, 0., w // 2, 0., w, h // 2, 0., 0., 1.]
and I am curious where that logic came from?

Ideally you would have the focal length in mm and the sensor size and then would use logic like this: https://github.com/google/mediapipe/blob/ecb5b5f44ab23ea620ef97a479407c699e424aa7/mediapipe/calculators/image/image_file_properties_calculator.cc#L52-L77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cancan101