csgo-vulkan-fix: Use InitialTitle instead of InitialClass as the class is now generic #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eded -vulkan option
…hanged to not be specific to CS2
daniel-Jones
changed the title
|
It applies the plugin to the steam settings window for the game as it sets the same title.. this is obviously not the ideal solution, but unless we just target "SDL Application" class I can't think of a better way. Unless we can force the class in the games launch options? |
|
a better way would be to finally make a windowrule for it |
|
What are your thoughts on how to detect cs2 for this windowrule? Or are you thinking the user will just match it to the title if they want? |
|
just add a windowrule and let the user pick what and how they want to match it, just like a windowrule. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point CS2 changed the class name to 'SDL Application'. The plugin no longer targets the game with it set to cs2. This PR changes the plugin to use the windows InitialTitle instead of InitialClass.
Not ideal if people are using it for something other than cs2, but the plugin is more aimed for the game.
Also removed the unnecessary -vulkan options as is isn't valid anymore.