Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binds: option to fullscreen pinned window #8526

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

littleblack111
Copy link
Contributor

@littleblack111 littleblack111 commented Nov 19, 2024

Describe your PR, what does it fix/add?

option to fullscreen pinned window

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

nope

Is it ready for merging, or does it need work?

ready

this stores the state in a var and apply pinned status back when
un-fullscrening
@littleblack111 littleblack111 marked this pull request as ready for review November 20, 2024 01:58
src/config/ConfigManager.cpp Outdated Show resolved Hide resolved
src/Compositor.cpp Outdated Show resolved Hide resolved
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, wiki mr needed

@littleblack111
Copy link
Contributor Author

Please review the wiki mr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants