Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renderer: add option to blur IME popups #8521

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ErrorNoInternet
Copy link
Contributor

@ErrorNoInternet ErrorNoInternet commented Nov 19, 2024

Describe your PR, what does it fix/add?

make it so that IME popups will be blurred by decoration:blur:enabled && decoration:blur:input_methods
image

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

i have no idea if this will break anything

Is it ready for merging, or does it need work?

ready

@littleblack111
Copy link
Contributor

not relevant but what skin is this and is it fcitx5?

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ni hao indeed

src/render/Renderer.cpp Outdated Show resolved Hide resolved
@ErrorNoInternet ErrorNoInternet changed the title renderer: make decoration:blur:popups apply to IME popups renderer: add option to blur IME popups Nov 20, 2024
@ErrorNoInternet
Copy link
Contributor Author

not relevant but what skin is this and is it fcitx5?

https://github.com/Reverier-Xu/Ori-fcitx5/ with my own modifications: diff.txt

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, wiki mr needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants